Bug 355324

Summary: kst fails to compile with gsl 2
Product: [Applications] kst Reporter: Orion Poplawski <orion>
Component: generalAssignee: kst
Status: RESOLVED FIXED    
Severity: normal CC: netterfield, nicos, stasnel, stupor_scurvy343
Priority: NOR    
Version: 2.0.8   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Patch to have kst compile with gsl 2

Description Orion Poplawski 2015-11-14 03:43:37 UTC
Working to update gsl in Fedora to 2.1.  kst fails with:

In file included from /builddir/build/BUILD/Kst-2.0.8/src/plugins/fits/exponential_unweighted/fitexponential_unweighted.cpp:24:0:
/builddir/build/BUILD/Kst-2.0.8/src/plugins/fits/exponential_unweighted/../non_linear.h: In function 'bool kstfit_nonlinear(Kst::VectorPtr, Kst::VectorPtr, Kst::VectorPtr, Kst::VectorPtr, Kst::VectorPtr, Kst::VectorPtr, Kst::ScalarPtr)':
/builddir/build/BUILD/Kst-2.0.8/src/plugins/fits/exponential_unweighted/../non_linear.h:180:40: error: 'struct gsl_multifit_fdfsolver' has no member named 'J'
           gsl_multifit_covar( pSolver->J, 0.0, pMatrixCovariance );
                                        ^
src/plugins/CMakeFiles/kst2_fits_exponential_unweighted.dir/build.make:74: recipe for target 'src/plugins/CMakeFiles/kst2_fits_exponential_unweighted.dir/fits/exponential_unweighted/fitexponential_unweighted.cpp.o' failed

Looks like the multifit api changed with gsl 2.
Comment 1 Nicolas Pavillon 2016-03-03 16:08:00 UTC
I can confirm the issue reported. It seems to me that it can be fixed with the attached patch.
Comment 2 Nicolas Pavillon 2016-03-03 16:08:50 UTC
Created attachment 97656 [details]
Patch to have kst compile with gsl 2
Comment 3 Netterfield 2016-03-29 21:21:25 UTC
Fixed by commit a9d24f91057441bbd2e3ed9e7536b071121526cb
D. Wiebe, March 10, 2016