Bug 355261

Summary:	Low quality input sources flags
Product:	[Applications] systemsettings	Reporter:	Viorel-Cătălin Răpițeanu <rapiteanu.catalin>
Component:	kcm_keyboard	Assignee:	Andriy Rysin <arysin>
Status:	REPORTED ---
Severity:	minor	CC:	aacid, nate, rapiteanu.catalin, simonandric5
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Viorel-Cătălin Răpițeanu 2015-11-12 17:29:37 UTC

The flags used for the input sources either don't have the correct aspect ratio, either they are pixelated. The flags of Romania and France should have the same aspect ratio (2:3) when they are displayed in the taskbar.

Reproducible: Always

Steps to Reproduce:
1. From 'Keyboard Hardware and Layout' select multiple keyboard layouts
2. Pick the Romanian, French and Nepal layout
3. Select 'Show flag' to see the the flag of the keyboard layout

Actual Results:  
- Romania's and France's flags are displayed as having different aspect ratio in the 'System Tray'.
https://cloud.githubusercontent.com/assets/4029937/8019435/3f1fb962-0c56-11e5-8514-eb7abcd6982b.png
- Nepals flag is pixelated. You can literally count the pixels of the Nepal's flag:
https://cloud.githubusercontent.com/assets/4029937/8019436/40ae0c66-0c56-11e5-9460-abbffaa498a3.png


Expected Results:  
- Romania's and France's flags show have the same aspect ratio (2:3) when they are displayed in the 'System Tray'.
- The flags show be rendered as 'svg' and not 'png'.

Referance: Nepal's flag: https://upload.wikimedia.org/wikipedia/commons/thumb/8/8e/Flag_of_Nepal_(19th_century-1962).svg/2000px-Flag_of_Nepal_(19th_century-1962).svg.png

Comment 1 Viorel-Cătălin Răpițeanu 2015-11-12 17:31:55 UTC

The current Nepal flag: https://upload.wikimedia.org/wikipedia/commons/thumb/9/9b/Flag_of_Nepal.svg/1000px-Flag_of_Nepal.svg.png

Comment 2 Viorel-Cătălin Răpițeanu 2016-06-05 16:18:07 UTC

The flags are installed by kde-runtime and can be found in:
l10n/$COUNTRY/flag.png

The reason why they are pixelated is because of their size. Quote from README file:
> You will need a nice flag for your country. The size should be 21x14
> pixels, and it should be called "flag.png".

Potential fixes for this problem would be:
1. Replacing the png format with the svg one, thing that would also require some modifications to kcontrol/locale/kcmlocale.cpp and khelpcenter/htmlsearch/klangcombo.cpp.
2. Improving the existing png resolution.

Any other suggestions? Will the format replacement (Fix 1) impact other components?

Comment 3 Albert Astals Cid 2016-06-05 22:53:13 UTC

I suggest you bring this either to the plasma or the frameworks devel mailing lists, not anything i can directly help with.