Bug 355151

Summary: Selecting active Project Bin clip doesn't update Effect Stack if clip in Timeline selected before
Product: [Applications] kdenlive Reporter: qubodup
Component: User Interface & MiscellaneousAssignee: Jean-Baptiste Mardelle <jb>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
URL: https://youtu.be/KbUUhzHtAeU
Latest Commit: Version Fixed/Implemented In: 15.12.0
Sentry Crash Report:

Description qubodup 2015-11-10 19:46:34 UTC 
Steps to reproduce:
1. Start Kdenlive
2. OPTIONAL Make effect stack, project bin and effect list visible at the same time (for better overview only)
3. Drag video into project bin
4. Drag clip from project bin into timeline
5. Drag effect onto clip in project bin
6. Select clip in project bin -> Effect Stack shows previously added effect
7. Select clip in timeline -> Effect Stack empty
8. Select clip in project bin

Expected result:
1. Effect Stack shows previously added effect

Actual result:
1. Effect Stack keeps showing the timeline's clip's effects (none)

Workaround for end-user:
1. Click on empty space in project bin
2. Click on clip in project bin

Commented video demonstrating bug:
https://youtu.be/KbUUhzHtAeU
Comment 1 Jean-Baptiste Mardelle 2015-11-14 01:17:11 UTC 
Git commit f08cc46d63c67bce62dc4f75615ace71859cb982 by Jean-Baptiste Mardelle.
Committed on 14/11/2015 at 01:17.
Pushed by mardelle into branch 'master'.

Correctly update effect stack when switching between timeline and project bin

M  +55   -47   src/bin/bin.cpp
M  +7    -24   src/bin/bin.h
M  +2    -0    src/mainwindow.cpp
M  +7    -7    src/timeline/customtrackview.cpp

http://commits.kde.org/kdenlive/f08cc46d63c67bce62dc4f75615ace71859cb982
Comment 2 qubodup 2015-11-14 02:44:04 UTC 
Thanks, confirmed resolved.

Video: https://youtu.be/zSlp-C4h9CY

There's a small weirdness when selecting white space in project bin, while a clip is selected in it but a timeline clip is active where the project bin selection becomes active for a splitsecond and then disappears: https://youtu.be/N7tmOjMSGa0

I guess the only issue might be that if there are very many effects active for that clip, that it could cause a slowdown.

This does not seem to happen when instead of white space, selecting another clip in the project bin.
Comment 3 Jean-Baptiste Mardelle 2015-11-15 13:22:03 UTC 
Git commit c372ce920394e0a9da8d8c0c6f41339b4c560c62 by Jean-Baptiste Mardelle.
Committed on 15/11/2015 at 13:21.
Pushed by mardelle into branch 'Applications/15.12'.

Fix effect stack selection glitch, fix drops not allowed when bin was in icon view

M  +62   -16   src/bin/bin.cpp
M  +18   -2    src/bin/bin.h
M  +0    -1    src/bin/projectclip.cpp
M  +5    -4    src/bin/projectitemmodel.cpp

http://commits.kde.org/kdenlive/c372ce920394e0a9da8d8c0c6f41339b4c560c62