Bug 354900

Summary:	Question marks at game win
Product:	[Applications] kmines	Reporter:	torhamzed
Component:	general	Assignee:	Dmitry Suzdalev <dimsuz>
Status:	RESOLVED FIXED
Severity:	minor	CC:	kde-games-bugs
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/kmines/f3455686463c0e4c79c1c7ae376d21ef05cdd9c8	Version Fixed In:
Attachments:	Empty cells Patch file Question marks

Description torhamzed 2015-11-05 14:47:05 UTC

Leaving question marks when the game is won blanks out the cells.

Reproducible: Always

Steps to Reproduce:
1. Do not flag all the cells
2. Win the game
3.


Expected Results:  
All cells should be flags when the game is won.

This happens on both KDE5 and KDE4 versions.  There are no crashes or other behavior that I can see.

Comment 1 torhamzed 2015-11-05 14:48:04 UTC

Created attachment 95329 [details]
Empty cells

Comment 2 torhamzed 2015-11-05 15:16:42 UTC

Created attachment 95331 [details]
Patch file

I created a patch(I think) for this using Kompare, a new if statement in the MineFieldItem::checkWon method that first checks for isQuestioned.

Comment 3 torhamzed 2015-11-05 15:21:39 UTC

Comment on attachment 95329 [details]
Empty cells

This was the second screenshot.

Comment 4 torhamzed 2015-11-05 15:22:13 UTC

Created attachment 95332 [details]
Question marks

Comment 5 Albert Astals Cid 2016-10-16 21:31:12 UTC

Git commit f3455686463c0e4c79c1c7ae376d21ef05cdd9c8 by Albert Astals Cid, on behalf of Torham Zed.
Committed on 16/10/2016 at 21:31.
Pushed by aacid into branch 'Applications/16.08'.

Fix clearing question marks at game win

Acked by Frederik Schwarzer
REVIEW: 128462

M  +2    -0    minefielditem.cpp

http://commits.kde.org/kmines/f3455686463c0e4c79c1c7ae376d21ef05cdd9c8