Summary: | Cantor: hardcoded include of luajit-2.0/lua.hpp | ||
---|---|---|---|
Product: | [Applications] cantor | Reporter: | Vadim A. Misbakh-Soloviov (mva) <kde> |
Component: | lua-backend | Assignee: | Filipe Saraiva <filipe> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | filipe, lucashnegri |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/cantor/0b6f7a5721e779dc6f67bc22d5b2511d010f19da | Version Fixed In: |
Description
Vadim A. Misbakh-Soloviov (mva)
2015-11-03 06:47:15 UTC
Maybe can you to provide a patch for it? This import is there since the first release, we never had problem with it (packagers never report it as a bug). Hi, Mea culpa. After years (and a change in the mantainer), LuaJIT bumped its version number. I will fix this. (In reply to Lucas Hermann Negri from comment #2) > Hi, > > Mea culpa. After years (and a change in the mantainer), LuaJIT bumped its > version number. I will fix this. Hi, Lukas. Unfortunately, it is still 2.0 in the cantor (and I still forced to locally patch it on every KF upgrade) :'( I'd suggest to just include lua.hpp there, but append $(pkg-config --cflags luajit) to C{,XX}FLAGS. It will be proper fix. Should I provide a patch for that fix, or you'll be fine to fix it directly in the code? (In reply to Vadim A. Misbakh-Soloviov (mva) from comment #3) > I'd suggest to just include lua.hpp there, but append $(pkg-config --cflags > luajit) to C{,XX}FLAGS. It will be proper fix. > > Should I provide a patch for that fix, or you'll be fine to fix it directly > in the code? Please Vadim, submit a patch for it so we can test and review your suggestion. Create a diff here https://phabricator.kde.org/differential/diff/create/ If you don't have a KDE Identity account, create one in https://identity.kde.org/index.php?r=registration/index and after it login to Phabricator and submit the patch. Git commit 0b6f7a5721e779dc6f67bc22d5b2511d010f19da by Filipe Saraiva, on behalf of Vadim A. Misbakh-Soloviov. Committed on 15/02/2017 at 18:21. Pushed by filipesaraiva into branch 'master'. Fix the hardcoded include for lua backend Currently Cantor has a hardcoded include to get lua.hpp library. This patch fix the search to include different versions of lua library. The hardcoded solution is no more necessary. Differential Revision: https://phabricator.kde.org/D4588 M +10 -11 cmake/FindLuaJIT.cmake M +1 -1 src/backends/lua/luaexpression.cpp M +1 -1 src/backends/lua/luahelper.cpp M +1 -1 src/backends/lua/luasession.h https://commits.kde.org/cantor/0b6f7a5721e779dc6f67bc22d5b2511d010f19da |