| Summary: | Effect Icons sometimes unreadable | ||
|---|---|---|---|
| Product: | [Applications] kdenlive | Reporter: | qubodup |
| Component: | User Interface & Miscellaneous | Assignee: | Jean-Baptiste Mardelle <jb> |
| Status: | RESOLVED WAITINGFORINFO | ||
| Severity: | minor | CC: | qubodup, wegwerf-1-2-3 |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | effects with icons | ||
|
Description
qubodup
2015-10-28 01:34:30 UTC
Created attachment 95170 [details]
effects with icons
The code is in src/effectslist/effectslistwidget.cpp, at line 289, in: QIcon EffectsListWidget::generateIcon(...) A patch is more than welcome. Many thanks, as far as I can tell, I was able to implement http://stackoverflow.com/questions/3942878/how-to-decide-font-color-in-white-or-black-depending-on-background-color (so far only in the effects list, not yet in the effect stack. I realized in the process however, that this colorful stuff is most likely to make kdenlive seem less professional and might also distract in the big picture. Looking at other video editors, I would suggest using good old icons instead, for now just two designs: one for video, one for audio and once categories have settled in, there might be room for individual icons (although unlikely, due to the limited 14x14px size). Should we work towards a solution now that is better than icons with effect-name-hash-derived colors and the effect's first letter or should we just fix this now and leave discussing improving the concept/idea of what is used as an icon later? Here is a montage of the current implementation, one with my changes, an icon version as well as some other color experiments: http://i.imgur.com/LAFO4oh.png And here's a gallery of full size screenshots: http://imgur.com/a/cCpE6 I just realized that 15.08 already had a/v icons in the list so it was obviously decided against. Allrighty then, I'll focus on finishing the readability. The idea of colored icons for the effects/transitions was in fact my idea, I have not really discussed it with other people. I can also see that it might make a "less professional" impression and might be distractive... So maybe a discussion on the forum might help to find out the best option. I am not against reverting to the old audio/video icons if most user prefer it... Thanks for the statement! I think the best would be to make one release with the fun icons so people can actually test it without having to compile the git version and see what the opinions are then. :) I'll try to finish the font color fix till 15.12 feature freeze! Qubodup, is this bug report still relevant? If not, I would like to ask you to close this bug report. Thank you very much for your cooperation! It still is, see screenshot. I won't be able to provide a patch. I can suggest to limit the background color to consist of RGB values, each would be 100 or more, to ensure a color spectrum, on top of which black would be readable. |
