Summary: | Explicit tab titles for tabs are reset when changing the profile options | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | thibaut.verron |
Component: | tabbar | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | a.samirh78, thibaut.verron |
Priority: | NOR | ||
Version: | master | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/konsole/78beb596800f33950adf0e18f1d5032bce5a000f | Version Fixed In: | 18.04 |
Description
thibaut.verron
2015-10-26 14:22:44 UTC
I can reproduce it using konsole 15.08.0 from Kubuntu as well. Git commit 78beb596800f33950adf0e18f1d5032bce5a000f by Kurt Hindenburg, on behalf of Ahmad Samir. Committed on 16/03/2018 at 01:13. Pushed by hindenburg into branch 'master'. Preserve tab titles set by the user, when applying profile changes Summary: When applying profile changes don't touch tab titles explicilty set by the user (via the rename tab dialog); the same goes when previewing color schemes. Update the tab text only if the user actually changed the the tab title fomart in the rename tab dialog. FIXED-IN: 18.04 Test Plan: - In a konsole window with 2 or more tabs, rename a tab using the rename-tab dialog - Open the Edit Profile dialog and change some settings and save, also try previewing some color schemes; note that the tab title changes are kept - In the Edit Profile dialog, change the tab format on the Tabs page, and apply; note that the tab title the was renamed by the user isn't changed but the tab(s) whose name wasn't changed are affected by the tab title format setting change - Open the rename-tab dialog, don't change anything and click OK; now konsole doesn't count that as a tab title change Reviewers: #konsole, hindenburg Reviewed By: #konsole, hindenburg Subscribers: #konsole Tags: #konsole Differential Revision: https://phabricator.kde.org/D11363 M +13 -0 src/Session.cpp M +15 -0 src/Session.h M +21 -9 src/SessionController.cpp M +5 -0 src/SessionController.h M +4 -2 src/SessionManager.cpp https://commits.kde.org/konsole/78beb596800f33950adf0e18f1d5032bce5a000f |