Summary: | Layer styles are not visible on layers with inherit alpha enabled | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Jyzee <jyzee.git> |
Component: | layer styles | Assignee: | Dmitry Kazakov <dimula73> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | halla, ngmstudio |
Priority: | NOR | Keywords: | regression |
Version First Reported In: | 2.9.8 | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/krita/3bf0a4f511249b784bb4f8d6de0a0bb6acce970d | Version Fixed In: | |
Sentry Crash Report: |
Description
Jyzee
2015-10-26 04:39:21 UTC
commit d3383be07fe3745a1462ff29c8c61bbf87e68eed Author: Dmitry Kazakov <dimula73@gmail.com> Date: Tue Sep 29 13:55:02 2015 +0300 Implemented projections for layer styles Now every layer style has it's own projection (or multiple projections), each with its own blending mode. The projections are free'd when the layer style filter is disabled. Fixes T217 Conflicts: krita/image/layerstyles/kis_ls_drop_shadow_filter.cpp krita/image/layerstyles/kis_ls_utils.h Add regression keyword and assign. *** Bug 393757 has been marked as a duplicate of this bug. *** Git commit d183945d306b12b6dbb3ea2dd94fb12b88532e24 by Dmitry Kazakov. Committed on 08/06/2018 at 08:48. Pushed by dkazakov into branch 'master'. Fix painting layer styles in Inherit Alpha mode The layer style projections (KisMultipleProjection) should be painted into the final stack using the blending mode selected by the user. M +2 -0 libs/image/kis_cached_paint_device.h M +32 -25 libs/image/kis_fill_painter.cc M +3 -7 libs/image/kis_fill_painter.h M +1 -1 libs/image/layerstyles/kis_layer_style_filter_projection_plane.cpp M +13 -14 libs/image/layerstyles/kis_ls_bevel_emboss_filter.cpp M +17 -27 libs/image/layerstyles/kis_ls_overlay_filter.cpp M +2 -0 libs/image/layerstyles/kis_ls_overlay_filter.h M +6 -8 libs/image/layerstyles/kis_ls_stroke_filter.cpp M +4 -17 libs/image/layerstyles/kis_ls_utils.cpp M +16 -2 libs/image/layerstyles/kis_multiple_projection.cpp M +3 -2 libs/image/layerstyles/kis_multiple_projection.h A +- -- libs/image/tests/data/fill_painter/patterns_fill__custom_origin.png A +- -- libs/image/tests/data/fill_painter/patterns_fill__null_origin.png M +55 -0 libs/image/tests/kis_fill_painter_test.cpp M +2 -0 libs/image/tests/kis_fill_painter_test.h M +1 -1 libs/image/tests/kis_layer_styles_test.cpp https://commits.kde.org/krita/d183945d306b12b6dbb3ea2dd94fb12b88532e24 Thia was not included in the latest bug fix release 4.0.4. Mistake? Git commit 3bf0a4f511249b784bb4f8d6de0a0bb6acce970d by Andrey Kamakin, on behalf of Dmitry Kazakov. Committed on 26/06/2018 at 14:18. Pushed by akamakin into branch 'akamakin/T8628-multithreading-optimization'. Fix painting layer styles in Inherit Alpha mode The layer style projections (KisMultipleProjection) should be painted into the final stack using the blending mode selected by the user. M +2 -0 libs/image/kis_cached_paint_device.h M +32 -25 libs/image/kis_fill_painter.cc M +3 -7 libs/image/kis_fill_painter.h M +1 -1 libs/image/layerstyles/kis_layer_style_filter_projection_plane.cpp M +13 -14 libs/image/layerstyles/kis_ls_bevel_emboss_filter.cpp M +17 -27 libs/image/layerstyles/kis_ls_overlay_filter.cpp M +2 -0 libs/image/layerstyles/kis_ls_overlay_filter.h M +6 -8 libs/image/layerstyles/kis_ls_stroke_filter.cpp M +4 -17 libs/image/layerstyles/kis_ls_utils.cpp M +16 -2 libs/image/layerstyles/kis_multiple_projection.cpp M +3 -2 libs/image/layerstyles/kis_multiple_projection.h A +- -- libs/image/tests/data/fill_painter/patterns_fill__custom_origin.png A +- -- libs/image/tests/data/fill_painter/patterns_fill__null_origin.png M +55 -0 libs/image/tests/kis_fill_painter_test.cpp M +2 -0 libs/image/tests/kis_fill_painter_test.h M +1 -1 libs/image/tests/kis_layer_styles_test.cpp https://commits.kde.org/krita/3bf0a4f511249b784bb4f8d6de0a0bb6acce970d |