Bug 354239

Summary: Search field in time zones dialogue in digital clock is missing a ‘Clear’ button
Product: [Plasma] plasmashell Reporter: Karl Ove Hufthammer <karl>
Component: Digital ClockAssignee: Martin Klapetek <mklapetek>
Status: RESOLVED FIXED    
Severity: minor CC: bugseforuns, kde, notuxius, plasma-bugs, russellgreene8
Priority: NOR    
Version: 5.4.2   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/plasma-workspace/commit/5244e2be7d748a36ea83f0109a26ebce46c5d68f Version Fixed In: 5.21
Sentry Crash Report:

Description Karl Ove Hufthammer 2015-10-23 06:17:58 UTC 
The search field in time zones dialogue in digital clock is missing a ‘Clear’ button. It should have one.

Reproducible: Always

Steps to Reproduce:
1. Right-click on the digital clock, and choose to configure it.
2. Select the time zone category.
3. Write something in the search field.


Actual Results:  
No ‘clear’ icon on the right of the search field appears.

Expected Results:  
A ‘clear’ icon on the right of the search field should appear.

Note that in the similar KCM time zones settings (*also* available when right-clicking on the digital clock, but a different menu item), a ‘clear’ icon does appear when you write in the search field.
Comment 1 Russell Greene 2015-12-27 02:12:51 UTC 
I am going to suggest that this goes on the wishlist, as it is not directly a bug but a feature request. Thank you!
Comment 2 Myriam Schweingruber 2015-12-27 10:58:01 UTC 
No, this is actually a bug, as search fields in KDE applications always have a clear button.
Comment 3 Kai Uwe Broulik 2015-12-27 17:15:25 UTC 
Unfortunately QtQuick.Controls TextField has no API to add buttons, so this won't be trivial.

In Plasma text fields (like KRunner) we have a custom style and can do whatever we want but in config dialogs where the native style is used, this is hard, if not impossible; at least not without using private API prone to break between releases.
Comment 4 Alexander Mentyu 2017-12-11 11:25:44 UTC 
'Holydays' section search field is missing clear button too
Comment 5 Nate Graham 2020-10-18 15:03:22 UTC 
Git commit 5244e2be7d748a36ea83f0109a26ebce46c5d68f by Nate Graham.
Committed on 18/10/2020 at 14:59.
Pushed by ngraham into branch 'master'.

[applets/digital-clock] Use Kirigami.SearchField for search field

That's what it was made for; might as well use it. This gives it a
"clear" button for free.
FIXED-IN: 5.21

M  +2    -3    applets/digital-clock/package/contents/ui/configTimeZones.qml

https://invent.kde.org/plasma/plasma-workspace/commit/5244e2be7d748a36ea83f0109a26ebce46c5d68f