Summary: | Going twice to effects kcm in systemsettings causes abort | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Martin Flöser <mgraesslin> |
Component: | effects-various | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED UPSTREAM | ||
Severity: | crash | CC: | alexey.min, wettererscheinung, xavier.besnard |
Priority: | NOR | Flags: | mgraesslin:
ReviewRequest+
|
Version: | git master | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
URL: | https://git.reviewboard.kde.org/r/125737/ | ||
See Also: |
https://bugs.kde.org/show_bug.cgi?id=352259 https://bugs.kde.org/show_bug.cgi?id=34439 |
||
Latest Commit: | http://commits.kde.org/kwin/76cd1fdc3411142991096adf8da9d7e74536f671 | Version Fixed In: | 5.4.3 |
Sentry Crash Report: |
Description
Martin Flöser
2015-10-21 09:49:39 UTC
possible cause and fix: https://codereview.qt-project.org/#/c/111932 Steps to reproduce match bug 351763. (In reply to Thomas Lübking from comment #1) > possible cause and fix: https://codereview.qt-project.org/#/c/111932 nope, I have that one in my Qt :-( But will nevertheless trigger a new Qt 5.5. build to verify. I found the reason for the crash: rootContext()->setContextProperty("engine", this); Will now try to remove that ;-) The problem is not the "this" pointer as I thought: setting twice a contextProperty is the problem. Does this bug look smilar to bug #353795 - https://bugs.kde.org/show_bug.cgi?id=353795#c1 ? *** Bug 353795 has been marked as a duplicate of this bug. *** Git commit 76cd1fdc3411142991096adf8da9d7e74536f671 by Martin Gräßlin. Committed on 21/10/2015 at 11:28. Pushed by graesslin into branch 'Plasma/5.4'. [kcmeffects] Do not use root context properties Apparently it's not allowed to set root context properties multiple times. If one goes to systemsettings, opens effects kcm, closes it and opens it again it crashes due to setting a context property with same name again. This change eliminates the need for the context property by modifying the property of the QML objects directly. Related: bug 351763 FIXED-IN: 5.4.3 REVIEW: 125737 M +2 -1 kcmkwin/kwincompositing/model.cpp M +0 -2 kcmkwin/kwincompositing/model.h M +0 -1 kcmkwin/kwincompositing/qml/EffectView.qml http://commits.kde.org/kwin/76cd1fdc3411142991096adf8da9d7e74536f671 *** Bug 361873 has been marked as a duplicate of this bug. *** (In reply to Martin Gräßlin from comment #8) > Apparently it's not allowed to set root context properties multiple Apparently that not it. According to bug #353795, QV4::Heap::String seems dangeling in QV4::String::toQString - the statemachine memory management is broken (thus recent changes to a new allocator implementation n Qt 5.6) and one cannot fix that with voodoo. *** Bug 362718 has been marked as a duplicate of this bug. *** |