Bug 354016

Summary: Spurious straight lines when leaving drawing area in presentation mode
Product: [Applications] okular Reporter: Oliver Sander <oliver.sander>
Component: generalAssignee: Okular developers <okular-devel>
Status: RESOLVED FIXED    
Severity: normal CC: aacid
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: http://commits.kde.org/okular/99667e4cfae903d9edd3958107c7bc61cfd91a5c Version Fixed/Implemented In:
Sentry Crash Report:

Description Oliver Sander 2015-10-17 18:46:04 UTC 
The following steps produce spurious lines when using the drawing tools in presentation mode.

1) Open a file
2) Go to presentation mode
3) Pick a drawing tool from the toolbar at the top
4) Start drawing.  Draw a line that leaves the page to the left or the right.
   (typically the screen is wider than the page, and there is a black area both to the left
   and to the right)
5) Continue drawing somewhere else on the page

Result: there is a line from the point where you left the drawing area in 4) to the point where started again in 5)


Reproducible: Always
Comment 1 Albert Astals Cid 2015-10-17 21:57:43 UTC 
Git commit 99667e4cfae903d9edd3958107c7bc61cfd91a5c by Albert Astals Cid.
Committed on 17/10/2015 at 21:57.
Pushed by aacid into branch 'master'.

Make leaving the presentation area finish the drawing

M  +48   -17   ui/presentationwidget.cpp

http://commits.kde.org/okular/99667e4cfae903d9edd3958107c7bc61cfd91a5c
Comment 2 Oliver Sander 2015-10-18 17:40:46 UTC 
Hi, many thanks for the quick fix.  Could somebody forward-port this to the 'frameworks' branch?  (I tried but failed.)  I need this fix together with the mult-color drawing feature in presentation mode.
Comment 3 Albert Astals Cid 2015-10-18 20:24:52 UTC 
And this is why you shouldn't be using a work branch. I've done a blind merge, i.e. it compiles, no idea if it works.
Comment 4 Oliver Sander 2015-10-18 20:44:53 UTC 
It does work, apologies for the hassle.  I do understand the problem, but with Tobias' recent improvements to the presentationwidget I am stuck on that branch now.