| Summary: | [text-tool] Artistic text tool can't type letter attributed to keyboard shortcuts | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | David REVOY <info> |
| Component: | Layers/Vector | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | critical | CC: | bugzilla, danilojunior, halla, krita |
| Priority: | NOR | ||
| Version: | 2.9.8 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/calligra/ed9c9859947705572a3327920ddedb742be49447 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
screenshot with text typed with letters that are also shortcuts
config files |
||
|
Description
David REVOY
2015-10-11 23:49:04 UTC
David beat me to this report, but I've encountered the same issue. Same problem, can't do the thing I wanted to do right now... Confirmed! I have custom shortcuts and I can't type these letter with text tool. krita 2.9.8.0 x64 windows 7 x64 , sp1 i7, 16gb, gtx 750 Created attachment 95211 [details]
screenshot with text typed with letters that are also shortcuts
Hm... I'm afraid I still haven't found a way to reproduce. I tried both with the default shortcuts and a new assigned shortcut. So I'm not sure what's up. Could someone who experiences this bug try with a clean configuration? On Linux, backup and remove .kde/share/apps/krita and .kde/share/config/kritarc. If that fixes the issue, I'd like a copy of the backed up configuration settings.
When I installed 2.9.7 it worked again... And no removing apps/krita and config/kritarc did not help, nevertheless I am uploading a zip of all the files. I am using Ubuntu 15.10 with Unity. Created attachment 95212 [details]
config files
maybe they are helpful / different
Thanks, I will check with those tomorrow on the train to work. Oh, wait... I was bisecting so I was on a version of Krita dating back to march. I'll check again after rebuilding 2.9. @Boudwijn I have tested with a clean configuration but the issue persist. Thanks for checking. I'm going to try and find the commit that caused the regression. that was commit 022f939c9d6c20f1717e1c81d10a5519f9de5f1d Author: David Faure <faure@kde.org> Date: Sat Aug 30 11:15:00 2014 +0200 Let Ctrl+Home/Ctrl+End go to top and bottom of text shape in stage. Much more expected than exiting edit-mode and going to the first or last page. This required to pass QEvent::ShortcutOverride event to tools, via viewmodes. The name shortcutOverrideEvent() is made up, QWidget doesn't have a specific virtual method for this and requires reimplementing event(QEvent*) instead. But I find that shortcutOverrideEvent is much nicer to have :) This new virtual method could be used to refine the earlier commits which implemented some blind rule ("keys without modifiers or with shift"), while the right way to do it is to accept the specific shortcuts handled by the current tool (which can also include shortcuts with CTRL or even ALT, and maybe does NOT include some shortcuts without modifiers, like PageUp or Esc...). CCMAIL: sven.langkamp@gmail.com Fix coming up tomorrow. Git commit 4086b11cf75a9b49a9f7eda8ca784856df9308ec by Boudewijn Rempt. Committed on 31/10/2015 at 07:40. Pushed by rempt into branch 'calligra/2.9'. We have two text tools, and in 022f939c9d6c20f1717e1c81d10a5519f9de5f1d only the multiline text tool was ported to the new shortcut override system. CCMAIL:faure@kde.org M +18 -0 plugins/artistictextshape/ArtisticTextTool.cpp M +2 -0 plugins/artistictextshape/ArtisticTextTool.h http://commits.kde.org/calligra/4086b11cf75a9b49a9f7eda8ca784856df9308ec Git commit a32f95f4ec4ad419eeab51578e15b5c450f1101a by Boudewijn Rempt. Committed on 31/10/2015 at 07:42. Pushed by rempt into branch 'master'. We have two text tools, and in 022f939c9d6c20f1717e1c81d10a5519f9de5f1d only the multiline text tool was ported to the new shortcut override system. CCMAIL:faure@kde.org M +18 -0 plugins/artistictextshape/ArtisticTextTool.cpp M +2 -0 plugins/artistictextshape/ArtisticTextTool.h http://commits.kde.org/krita/a32f95f4ec4ad419eeab51578e15b5c450f1101a Thank you for the bug-fix ! I just tested the new commits and it's perfect. :-) Git commit ed9c9859947705572a3327920ddedb742be49447 by Friedrich W. H. Kossebau, on behalf of Boudewijn Rempt. Committed on 10/11/2015 at 06:04. Pushed by kossebau into branch 'master'. We have two text tools, and in 022f939c9d6c20f1717e1c81d10a5519f9de5f1d only the multiline text tool was ported to the new shortcut override system. CCMAIL:faure@kde.org M +18 -0 plugins/artistictextshape/ArtisticTextTool.cpp M +2 -0 plugins/artistictextshape/ArtisticTextTool.h http://commits.kde.org/calligra/ed9c9859947705572a3327920ddedb742be49447 |