Bug 353661

Summary:	Demo (seemingly) infinite loop on games that cannot be won
Product:	[Applications] kpat	Reporter:	lordmetgod
Component:	solver	Assignee:	Stephan Kulow <coolo>
Status:	RESOLVED NOT A BUG
Severity:	minor	CC:	kde-games-bugs-null
Priority:	NOR
Version First Reported In:	3.6
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description lordmetgod 2015-10-07 18:41:28 UTC

Obviously this isn't that big of a deal but when it says it cannot be won (but before it says the game is lost i.e. no demo mode possible - or I don't think it has it then) if you use demo mode it will enter an infinite loop (at least until the kpat is closed or the round is terminated). For what its worth, this was under Klondike - I've not tried others.

I should also point out that if there are any things that can be done (e.g. it comes across a two of clubs when the ace of clubs is already out) then it will do that but then it will still loop after that (e.g. if there are still cards left in the pile then it will loop through them). I'm sure there are other loops but the cited example is what I encountered based on the conditions of the game that was impossible to win.

Reproducible: Didn't try

Steps to Reproduce:
I actually haven't tried but only because I just noticed it and I haven't come across a game that cannot be won, to test it again. I presume it would happen again in the same manner:
1. Be unlucky enough to have a game that cannot be won.
2. Before it says the game is lost (some moves later), activate demo mode.

Actual Results:
It loops as described in the details.

Expected Results:
It would seem to me that if the game cannot be won then the demo is if not completely disabled, then it stops after one loop of doing nothing.

Version 3.6, KDE Dev Platform 4.14.9

I'm marking the severity as minor because it is possible to disable the demo, not use the demo under such circumstances or even stop the game (new round or close kpat).

Comment 1 Stephan Kulow 2015-10-08 11:24:09 UTC

it's not doing nothing, it's playing valid moves until you stop it. As klondike's nature is cyclic, so is the demo.

Comment 2 Justin Zobel 2022-10-14 05:46:55 UTC

Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported and confirmed, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "CONFIRMED" when replying. Thank you!

Comment 3 Bug Janitor Service 2022-10-29 05:02:35 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

Comment 4 lordmetgod 2022-10-29 11:33:07 UTC

(In reply to Bug Janitor Service from comment #3)
> Dear Bug Submitter,
> 
> This bug has been in NEEDSINFO status with no change for at least
> 15 days. Please provide the requested information as soon as
> possible and set the bug status as REPORTED. Due to regular bug
> tracker maintenance, if the bug is still in NEEDSINFO status with
> no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
> due to lack of needed information.
> 
> For more information about our bug triaging procedures please read the
> wiki located here:
> https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging
> 
> If you have already provided the requested information, please
> mark the bug as REPORTED so that the KDE team knows that the bug is
> ready to be confirmed.
> 
> Thank you for helping us make KDE software even better for everyone!

I'm very sorry but I hardly ever use that system any more so I can't provide more information. I totally forgot about this and since it's been so many years my guess is it's fine to close this. If it's not fixed I don't know but I'm afraid that I can't easily help. Given that I reported it more than 7 years ago I'm not really bothered.

Comment 5 lordmetgod 2022-10-29 11:36:35 UTC

(In reply to Stephan Kulow from comment #1)
> it's not doing nothing, it's playing valid moves until you stop it. As
> klondike's nature is cyclic, so is the demo.

Okay but this is an utter waste of CPU cycles and not useful. It might have been that it wasn't playing valid moves (meaning that it continued to loop over and over again even when it fails) but I don't know. Either way it's wasteful and should be addressed. However as I noted in another comment this was over 7 years ago (I don't recall seeing you reply either way) and I hardly ever use that system any more so whether it's fixed or not I don't know but it honestly doesn't concern me. It probably has been fixed but if not oh well. I have too much going on these days and the only way I use that system these days is ssh in.

Comment 6 Bug Janitor Service 2022-11-13 05:14:21 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

Comment 7 lordmetgod 2022-11-13 16:23:46 UTC

I'm sorry but this is rather ridiculous. What information can I provide beyond what I did (contrary to what the system says I did provide some information just not what you want since I cannot provide that)? Even if I still used the system besides ssh (which as I said I don't) it's been many years so the version I reported this when finally getting back anything is long gone. So I would be providing you with information that is not even valid. That would be unhelpful and it's a waste of time for all of us.

As far as I am concerned you can close this bug but please don't expect me to take care of the status etc. I have too much going on now. I appreciate that you finally got to it and I know very well it's all voluntary work (I also do voluntary work) but I can't be expected to provide information for something from many years ago. I don't know what status to make it so I won't bother changing it.

Stay safe.

Comment 8 Bug Janitor Service 2022-11-28 05:12:28 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

Comment 9 Stephan Kulow 2022-11-28 05:45:43 UTC

Let's kill this. There is no interest to optimize demos.