| Summary: | Keyboard layout switch button in the lockscreen is tiny and its text overflows | ||
|---|---|---|---|
| Product: | [Unmaintained] ksmserver | Reporter: | Jan Kundrát <jkt> |
| Component: | lockscreen | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | blackredprince, chgonzalezg, clearmartin, kiril, null |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/plasma-framework/1a4c1d7eebcf1e901b3109b26bae70c56a80f0d2 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Photo of wrong text wrap
Missing keyboard layout at all |
||
|
Description
Jan Kundrát
2015-10-06 01:03:27 UTC
Created attachment 95027 [details]
Photo of wrong text wrap
Oh wow, that's bad. Will fix, thanks Git commit 1a4c1d7eebcf1e901b3109b26bae70c56a80f0d2 by David Edmundson. Committed on 19/10/2015 at 10:30. Pushed by davidedmundson into branch 'master'. Fix Button minimumWidth property Plasma's Button has an extra property "minimumWidth" which is an extra hint not in QQC to say "what is the size to exactly fit the contents". (it's a bit confusing, as we can perfectly handle a button below it's "minmimum" size) This should be based on the size the contents want to be (the implicitWidth), not how small the contents can go (which with is pretty meaningless when our button can elide) It got broken at some point recently. Change-Id: I637898c3abf98183bbae30d8f15c4d72801a3650 REVIEW: 125698 M +3 -2 src/declarativeimports/plasmastyle/ButtonStyle.qml M +12 -1 tests/components/button.qml http://commits.kde.org/plasma-framework/1a4c1d7eebcf1e901b3109b26bae70c56a80f0d2 On my machine I can see that the layout switch button in the lockscreen is too tiny, too, but before I click it I see no layout whatsoever. So, when I go to the lockscreen I simply see the empty button without knowing which is the current layout (see attached file). After I actually click it I get the same result as Jan Kundrát. As far as I can see you're fixing the minimum width of this button, but could it be that the actual issue is a fail in retrieval the current keyboard layout initially when starting the lockscreen? I'm not sure how/when this is possible, because I've never succeeded when trying to make `qdbus org.kde.keyboard /Layouts org.kde.KeyboardLayouts.getCurrentLayout` fail, however. I will not re-open that one, because I'm not sure if my assumption is correct. Can you try it first? Created attachment 95201 [details]
Missing keyboard layout at all
@Kiril: I have exactly the same issue you are having. After applying the above patch all is fine again, the button is not empty anymore. *** Bug 356021 has been marked as a duplicate of this bug. *** |