Bug 353096

Summary: The “Highlight Windows” option makes it impossible to use the right-click menu of task manager icons
Product: [Plasma] plasmashell Reporter: Chris Warrick <kwpolska>
Component: Icons-only Task ManagerAssignee: Eike Hein <hein>
Status: RESOLVED FIXED    
Severity: major CC: bvbfan, kde, m32online, plasma-bugs-null, thomas.luebking
Priority: NOR    
Version First Reported In: 5.4.1   
Target Milestone: 1.0   
Platform: Arch Linux   
OS: Linux   
Latest Commit: http://commits.kde.org/plasma-desktop/5e95ef677ea5dd09137dcf7b88847b436ad572b3 Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Patch to add context menu to highlighted windows

Description Chris Warrick 2015-09-23 17:37:24 UTC 
When I try to right-click a task icon (to close it, or to pin it to my taskbar, or…), the transparency effect from "Highlight Windows" kicks in. Since the right-click menu is not the application window, it becomes invisible and unusable (without guessing at least).

Reproducible: Always

Steps to Reproduce:
1. Enable "Highlight Windows".
2. Right click on an icon.
3. Try to use a right-click option.  Good luck!
Comment 1 Eike Hein 2015-10-13 19:36:24 UTC 
*** Bug 353744 has been marked as a duplicate of this bug. ***
Comment 2 Eike Hein 2015-10-18 17:07:33 UTC 
Created attachment 95036 [details]
Patch to add context menu to highlighted windows

I've tried the same as Kai in bug 53744 with the same results. I'm attaching the patch here. Thomas, any further thoughts?
Comment 3 Anthony Fieroni 2015-11-06 17:55:53 UTC 
5.4.2 pre still present.
Comment 4 Anthony Fieroni 2015-11-06 17:56:22 UTC 
i mean 5.4.3 pre :)
Comment 5 Anthony Fieroni 2015-11-21 03:11:17 UTC 
plasma 5.4.95 still present
Comment 6 David Edmundson 2015-11-22 00:52:36 UTC 
> Thomas, any further thoughts? 

which Thomas?
Comment 7 Eike Hein 2015-11-22 00:58:00 UTC 
The one I expected to be in the CC list after the dupe merge above :)
Comment 8 Thomas Lübking 2015-11-22 08:18:51 UTC 
iirc there's some trouble with the way Qt5 creates popups, the WId changes.

=> For a quick try use "QTimer::singleShot(100, this, updateWindowHighlight());" if that works, we'd need to check when we can actually rely on the winId() of the popup.
Comment 9 Anthony Fieroni 2016-01-02 13:36:51 UTC 
Any progress here?
Comment 10 Eike Hein 2016-01-21 21:11:08 UTC 
Git commit 5e95ef677ea5dd09137dcf7b88847b436ad572b3 by Eike Hein.
Committed on 21/01/2016 at 21:09.
Pushed by hein into branch 'Plasma/5.5'.

Cancel window highlight when opening the context menu.

M  +5    -0    applets/taskmanager/plugin/backend.cpp

http://commits.kde.org/plasma-desktop/5e95ef677ea5dd09137dcf7b88847b436ad572b3
Comment 11 Eike Hein 2016-01-21 21:11:08 UTC 
Git commit 5e95ef677ea5dd09137dcf7b88847b436ad572b3 by Eike Hein.
Committed on 21/01/2016 at 21:09.
Pushed by hein into branch 'Plasma/5.5'.

Cancel window highlight when opening the context menu.

M  +5    -0    applets/taskmanager/plugin/backend.cpp

http://commits.kde.org/plasma-desktop/5e95ef677ea5dd09137dcf7b88847b436ad572b3
Comment 12 M32o 2016-08-12 10:30:50 UTC 
curious....resolved but exactly this bug is present in arch linux plasmashell --version - 5.7.3
Comment 13 Eike Hein 2016-08-12 10:32:49 UTC 
Can't reproduce - opening the context menu cancels window highlight here.