| Summary: | ark don't warn about broken rar file | ||
|---|---|---|---|
| Product: | [Applications] ark | Reporter: | dmr drk <dmr.drk> |
| Component: | general | Assignee: | Raphael Kubo da Costa <rakuco> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | elvis.angelaccio, rthomsen6, simonandric5 |
| Priority: | NOR | ||
| Version: | 2.19 | ||
| Target Milestone: | --- | ||
| Platform: | Debian stable | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/ark/170115f17e2be3e1703efe5cec6fea8e762ddd67 | Version Fixed In: | 15.12.0 |
| Sentry Crash Report: | |||
| Attachments: | rar sample | ||
|
Description
dmr drk
2015-09-20 18:06:09 UTC
Thanks for reporting. Can you try with a more recent version such as Ark 15.08.1? Also, can you upload an affected archive here? i have not upgraded to kde5 yet. i have meant extraction error dialog, to be clear, not just open. and there is no progress dialog. Can you upload a broken rar archive here by using "Add an attachment"? Created attachment 94674 [details]
rar sample
it is from rarlab.com themes, actual size is 105 KB and unfinished download.
Git commit 170115f17e2be3e1703efe5cec6fea8e762ddd67 by Ragnar Thomsen. Committed on 04/10/2015 at 13:59. Pushed by rthomsen into branch 'master'. Improve handling of corrupt archives by CliPlugins A new parameter was added to the Kerfuffle::CliInterfaceParameters enum (called CorruptArchivePatterns), containing a list of regexps matching output from CliPlugins when a corrupt archive is listed. Due to the CliInterface not being able to launch a KMessageBox itself, a query (LoadCorruptQuery) was added which launches a KMessageBox::warningYesNo asking the user if he wants to try to load the corrupt archive. This is useful because some files might still be recoverable. If the user answers no, loading of the archive is cancelled. If the user answers yes the archive is loaded as usual, but to prevent the user from trying to add/delete files from the corrupt archive (which is likely to fail), the archive is set to readonly. This necessitated a new private member in ReadOnlyArchiveInterface (m_isCorrupt) and getter/setter functions. The setter function is used in CliInterface::HandleLine, while the getter function is used in ReadWriteArchiveInterface::isReadOnly(). Related: bug 261073 FIXED-IN: 15.12.0 REVIEW: 125363 M +17 -3 kerfuffle/archiveinterface.cpp M +3 -0 kerfuffle/archiveinterface.h M +13 -0 kerfuffle/cliinterface.cpp M +5 -0 kerfuffle/cliinterface.h M +24 -0 kerfuffle/queries.cpp M +21 -0 kerfuffle/queries.h M +2 -0 plugins/cli7zplugin/cliplugin.cpp M +2 -0 plugins/clirarplugin/cliplugin.cpp M +1 -0 plugins/clizipplugin/cliplugin.cpp http://commits.kde.org/ark/170115f17e2be3e1703efe5cec6fea8e762ddd67 |