Summary: | Crash on delete into image editor [patch] | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Dave Gilbert <gilbertd+kde> |
Component: | Database-Trash | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | caulier.gilles, kevin.kofler, luigi.toscano, metzpinguin, rdieter, simonandric5 |
Priority: | NOR | ||
Version: | 4.13.0 | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/digikam/5dde5352fa11d31bb77149cc029319f42b0e05ea | Version Fixed In: | 4.14.0 |
Attachments: | editor.patch |
Description
Dave Gilbert
2015-09-19 18:55:31 UTC
*** This bug has been marked as a duplicate of bug 222974 *** (In reply to Gilles Caulier from comment #1) > > > *** This bug has been marked as a duplicate of bug 222974 *** Are you sure that's the write bug to dupe to - that was closed having been fixed 5 years ago; this is a failure on a current release. The problem is relevant of KDirWatch from KDELibs. Look well old bug. (In reply to Gilles Caulier from comment #3) > The problem is relevant of KDirWatch from KDELibs. Look well old bug. But since that bug was marked closed/fixed in 4.4 it doesn't sound right to dupe my bug to it, since it's happening on 4.13 (In reply to Gilles Caulier from comment #3) > The problem is relevant of KDirWatch from KDELibs. Look well old bug. Where is the mention of KDirWatch in the stacktrace? The original bug had: #6 0x00007f3337b2b10b in findSubEntry (path=<value optimized out>, this=<value optimized out>) at /usr/src/debug/kdelibs-4.3.87svn1070744/kio/kio/kdirwatch_p.h:161 There is no mention of either KDirEntry or findSubEntry in this stacktrace. Moreover, according the reproduce, it happens now with an easy reproducer. Can you please reconsider? This cannot possibly be a duplicate of bug #222974, because (as pointed out by the reporter), that bug was fixed in 4.4.1 and this bug was reported against Fedora 23, which ships kdelibs 4.14.12. Look on duplicate bug. There a few files with similar backtrace where KDirWatch is present. There is no reason to see digiKam crashing while deletion of file. There are plenty of reports relevant of file deletion and KDirWatch. When a file is removed, KDirWatch detect changes from hard drive to update database. Created attachment 94667 [details]
editor.patch
This patch fix the timing issue when deleting modified images in the editor.
Maik
Maik, Even if i cannot reproduce the race condition crash, the patch sound fine for me. Gilles Caulier (In reply to Gilles Caulier from comment #9) > Even if i cannot reproduce the race condition crash... Is quite possible with faster disk and computer, I commit the patch. Maik Git commit 5dde5352fa11d31bb77149cc029319f42b0e05ea by Maik Qualmann. Committed on 21/09/2015 at 20:35. Pushed by mqualmann into branch 'master'. apply patch #94667 to fix possible crash when deleting modified image in the image editor FIXED-IN: 4.14.0 M +2 -1 NEWS M +33 -0 utilities/imageeditor/editor/editorwindow.cpp M +1 -0 utilities/imageeditor/editor/editorwindow.h M +9 -1 utilities/imageeditor/main/imagewindow.cpp http://commits.kde.org/digikam/5dde5352fa11d31bb77149cc029319f42b0e05ea Git commit dd05243e953a4be34f227ad15522283f4c0dbf93 by Gilles Caulier. Committed on 23/09/2015 at 23:04. Pushed by cgilles into branch 'frameworks'. backport commit #5dde5352fa11d31bb77149cc029319f42b0e05ea from git master to frameworks branch M +33 -0 utilities/imageeditor/editor/editorwindow.cpp M +1 -0 utilities/imageeditor/editor/editorwindow.h M +9 -1 utilities/imageeditor/main/imagewindow.cpp http://commits.kde.org/digikam/dd05243e953a4be34f227ad15522283f4c0dbf93 |