Bug 352816

Summary:	15.11.80, Add feature to enable/disable showing of frames in clip & project monitors
Product:	[Applications] kdenlive	Reporter:	Unknown <null>
Component:	User Interface & Miscellaneous	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	minor	CC:	wegwerf-1-2-3
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
URL:	https://www.dropbox.com/s/imdquo860v2mknc/frame_number_kdenlive.png?dl=0
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Unknown 2015-09-16 22:33:13 UTC

I like the fact that we can now easily see the frame # in the clip and project monitors of Kdenlive, but can they be made optional? Perhaps have a check box in the "View" section of the menu bar saying something like "monitor frames" or "clip frames", or possibly have a check box when you right-click either clip or project monitor that says "Show clip frames" or "Show frames"? Possible have both?

Reproducible: Always



Expected Results:  
I'd say proposed results:
(1) Right-click on clip or project monitor to open right-click-menu (sorry, I don't know the proper name for it).
(2) have click-able check box to enable/disable showing the frames in that particular monitor.

This would be monitor independent, mind you. So one could be enabled, while the other disabled.

Running Kdenlive 15.08.0+git20150916.0302+15.10-0_amd64 on Kubuntu 15.10 x64 beta (downloaded packages from kubuntu-ci/unstable ppa), KDE Plasma 5.4.1.

Comment 1 Unknown 2015-11-26 22:01:20 UTC

Issue is still present in Kdenlive 15.11.80. This bug was originally posted as a suggestion, but I really feel it should be an choice for the user to turn the red frame # indicator on and off in the monitors.

Comment 2 Jean-Baptiste Mardelle 2015-11-27 08:10:29 UTC

The frame number can be turned off if you disable the "Monitor Info Overlay" option in Monitor menu. This also disables the overlay showing if you are on a marker or if you are a an in / out position.

Is it ok for you or should I completely remove that frame numbering ? Not sure it is really needed...

Comment 3 Jean-Baptiste Mardelle 2015-11-27 08:11:29 UTC

Forgot to say it is currently affecting both monitors but I could change that..

Comment 4 Wegwerf 2015-11-27 10:21:17 UTC

I personally don't understand the usecase for the frame display when there is already a timecode/frame display+input just sitting below it. I would also like to at least be able to disable it without loosing the more important in/out position notification. But if there is no usecase for it, removing it would avoid the lava code anti-pattern, where code gets so hard like lava after some time and noone dares to remove it.

Comment 5 Unknown 2015-12-06 20:01:32 UTC

JB, my bad. I try not to make these bugs without seeing if the issue is my ignorance with the program. Not looking to consume your time with "how-to" bugs. :)

That said, glad to know this is an option. However, like wegwerf said, this isn't really needed at all in the professional (or dare I say casual) film editing world.

While it's great to have the feature if needed - as always, features are cool :) - I would suggest you have it disabled by default, and have users opt in to enabling it.

Comment 6 Jean-Baptiste Mardelle 2015-12-07 20:50:04 UTC

Git commit 1fde3be31c866176aad156155b4db874b108c0ce by Jean-Baptiste Mardelle.
Committed on 07/12/2015 at 20:49.
Pushed by mardelle into branch 'Applications/15.12'.

Remove frame number in monitor overlay until we implement a proper UI to display it

M  +0    -21   data/kdenlivemonitor.qml
M  +3    -1    src/monitor/monitor.cpp

http://commits.kde.org/kdenlive/1fde3be31c866176aad156155b4db874b108c0ce

Comment 7 Jean-Baptiste Mardelle 2016-01-01 01:06:02 UTC

This is now fully configurable in git master

Comment 8 Wegwerf 2016-01-01 15:46:02 UTC

Seen this yesterday and played with it: very useful. Thank you very much for the work you spent on improving Kdenlive's usability! Happy New Year!