Summary: | Wine/valgrind: Warning: noted but unhandled ioctl 0x5307 with no size/direction hints. (CDROMSTOP) | ||
---|---|---|---|
Product: | [Developer tools] valgrind | Reporter: | Austin English <austinenglish> |
Component: | general | Assignee: | Julian Seward <jseward> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 3.10 SVN | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: |
patch1
patch2 |
Description
Austin English
2015-09-15 19:50:50 UTC
Austin, do you have a patch for this? Or for bug 348616 ? (In reply to Julian Seward from comment #1) > Austin, do you have a patch for this? Or for bug 348616 ? Not currently, but I took a quick look. There are several more syscalls that wine uses in the source that are bsd/osx specific, but I can't easily test. Should I stub those / put fixme's, or just fix linux/generic? Or only fix the two that currently have bugs? (In reply to austinenglish@gmail.com from comment #2) > Not currently, but I took a quick look. There are several more syscalls that > wine uses in the source that are bsd/osx specific, but I can't easily test. > Should I stub those / put fixme's, or just fix linux/generic? Or only fix > the two that currently have bugs? Sorry for slow response. I'd suggest you only fix the cases you can actually test, since I prefer not to have unverified code in the tree. Created attachment 101937 [details]
patch1
This adds missing ioctl defines to cdrom ioctls
Created attachment 101938 [details]
patch2
(In reply to Austin English from comment #5) > Created attachment 101938 [details] > patch2 Committed, r16152. Thanks for the patch. |