Bug 352654

Summary:	Button highlight makes it unreadable in dark themes
Product:	[Plasma] Breeze	Reporter:	kdebuac.rhn
Component:	QStyle	Assignee:	Hugo Pereira Da Costa <hugo.pereira.da.costa>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugs.kde.org, hugo.pereira.da.costa, nate
Priority:	NOR
Version First Reported In:	5.14.3
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Screenshot of button highlight White-on-white while not hovering with mouse

Description kdebuac.rhn 2015-09-13 10:29:35 UTC

The Zion Dark theme button highlight is faulty - it highlights to white instead of a dark color, resulting in low contast when a button is clicked / hovered.

The bug is not straightforward to reproduce because button highlights setting carries over from the previous theme for some time.

Reproducible: Sometimes

Steps to Reproduce:
1. Change theme to Zion Dark
2. Relogin (or at least restart application)
3. Click some buttons (e.g. system settings->Colors->back to Overview)

Actual Results:  
Buttons become white on click.

Expected Results:  
Buttons highlight to some color matching theme on click.

Fedora 22

Comment 1 Hugo Pereira Da Costa 2015-09-13 10:39:30 UTC

Could you post a screenshot ?

Comment 2 Hugo Pereira Da Costa 2015-09-13 10:44:39 UTC

I cannot reproduce the issue in Oxygen, but definitly with Breeze.
This is because the mouse-over color is basically the same as the foreground color.
It is even brighter than the focus color.
I'm afraid it is an issue with the color scheme however, rather than with the style itself.
For instance, it would seem more natural to me to have a mouse-over color close to the selection color, but lighter, and the same for the focus color.

Comment 3 kdebuac.rhn 2015-09-13 11:38:25 UTC

Created attachment 94536 [details]
Screenshot of button highlight

Comment 4 Erik Quaeghebeur 2019-01-23 11:29:13 UTC

I can confirm that this is currently still an issue with (many? all?) dark themes.

@Hugo:
1. if this bug should be put elsewhere, can you reassign product/component/assignee?
2. Can you provide a workaround? (Based on your earlier comment, I feel there might be one.)

Comment 5 Erik Quaeghebeur 2019-01-23 11:36:28 UTC

Created attachment 117620 [details]
White-on-white while not hovering with mouse

BTW, this does also happen when the button is just focused (active?), so this is not just about mouse-over. (Added attachment showing this.)

Comment 6 Erik Quaeghebeur 2019-01-23 11:40:05 UTC

Possibly related: Bug 354627

Comment 7 Nate Graham 2021-02-16 20:50:12 UTC

This was fixed a while back. Any remaining issues would be an instance of Bug 354627, or similar.