| Summary: | Another "use function returning reference to temporary" problem lead to crash | ||
|---|---|---|---|
| Product: | [Applications] kdevelop | Reporter: | Zhang Jingqiang <zh_jq> |
| Component: | general | Assignee: | kdevelop-bugs-null |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | ||
| Priority: | NOR | ||
| Version: | 4.7.1 | ||
| Target Milestone: | --- | ||
| Platform: | Debian unstable | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kdevelop/b211a552ac8d6b0094ac81234422f9cae7e79ddb | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | the patch to fix the problem | ||
Created attachment 94519 [details]
the patch to fix the problem
Git commit b211a552ac8d6b0094ac81234422f9cae7e79ddb by Milian Wolff, on behalf of Jingqiang Zhang. Committed on 04/10/2015 at 11:12. Pushed by mwolff into branch '4.7'. Fix one more use of function return refer to temp variable. REVIEW: 125404 M +1 -1 languages/cpp/cppduchain/environmentmanager.cpp http://commits.kde.org/kdevelop/b211a552ac8d6b0094ac81234422f9cae7e79ddb |
languages/cpp/cppduchain/environmentmanager.cpp line 235: for( ReferenceCountedStringSet::Iterator it(conflicts.iterator()); it; ++it ) { - if (!environmentMacroNames.contains(it.ref())) { + if (!environmentMacroNames.contains( *it )) { continue; } All ReferenceCountedStringSet::Iterator ones need to be fixed. Reproducible: Always