| Summary: | standard home folder should use folder-xxxx | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | andreas_k <andreas_k> |
| Component: | general | Assignee: | David Faure <faure> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | frank78ac, ht990332, kdelibs-bugs, simonandric5, sitter |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Kubuntu | ||
| OS: | Linux | ||
| URL: | https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/DolphinHome.png | ||
| Latest Commit: | http://commits.kde.org/kio/93d71cdd19a6a844363751bd0299205d00d9a3a6 | Version Fixed In: | 5.16 |
| Sentry Crash Report: | |||
|
Description
andreas_k
2015-09-09 21:34:57 UTC
Thanks for the report. If I understand you correctly, then you suggest that these folders, which are created automatically for new users, get different icons? This is not a Dolphin issue. The process which creates these directories (which might be run by the distro?) should then create a .directory file inside each folder which specifies the icon. The icons will then also be shown in the file dialog, Folder View and anywhere else where you can display folder contents (this could never be achieved by a change in Dolphin itself!). Or did I misunderstand something? no that's right. the only problem is that I don't know where I should report the bug that it can be solved. (In reply to andreas_k from comment #2) > no that's right. the only problem is that I don't know where I should report > the bug that it can be solved. That depends on who is responsible for creating these folders. I had thought that it might be the distro, but maybe there is something in KDE that I'm not aware of that creates these folders. Maybe someone else has an idea. kfileitem.cpp needs to map nonsense accordingly *** Bug 352715 has been marked as a duplicate of this bug. *** According to my suggestion in Bug 352715, just check if ~/.config/user-dirs.dirs exists. If it does, use specific icons for locations specified in that file as defaults (without writing to .directory files). It that file does not exist, show plain looking folder icons by default. Then if the user customizes, .directory files are created and they override the default icons. Basically reserve .directory files to customizations. Some references to what I am trying to hint at: http://freedesktop.org/wiki/Software/xdg-user-dirs/ https://wiki.archlinux.org/index.php/Xdg_user_directories http://manpages.ubuntu.com/manpages/vivid/man1/xdg-user-dirs-update.1.html Git commit 93d71cdd19a6a844363751bd0299205d00d9a3a6 by Harald Sitter. Committed on 22/10/2015 at 07:26. Pushed by sitter into branch 'master'. add logic to use icons for default xdg user dirs this acts as an additional fallback to mimetype iconing and .directory overrides. xdg user dirs are relocatable and can change depending on user locale as well as user configuration and additionally are used in a range of different desktop environments making this a very runtime sort of decision. REVIEW: 125158 CHANGELOG: Using suitable icons for default folders in the user home FIXED-IN: 5.16 M +13 -0 autotests/kfileitemtest.cpp M +1 -0 autotests/kfileitemtest.h M +46 -2 src/core/kfileitem.cpp http://commits.kde.org/kio/93d71cdd19a6a844363751bd0299205d00d9a3a6 |
