| Summary: | edit bundle creates a new bundle | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | David REVOY <info> |
| Component: | Resource Management | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | griffinvalley, halla |
| Priority: | NOR | ||
| Version: | 2.9.8 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/krita/7c8f66a20c04ef02d734426d5ce806d710636214 | Version Fixed In: | |
| Sentry Crash Report: | |||
Git commit 86cbc6cddad65b1e92e627e5970c480c6bae1fb4 by Boudewijn Rempt. Committed on 20/03/2016 at 14:51. Pushed by rempt into branch 'master'. The new bundle isn't created with the current settings of the bundle you want to edit yet... M +7 -5 plugins/extensions/resourcemanager/dlg_bundle_manager.cpp M +5 -3 plugins/extensions/resourcemanager/dlg_bundle_manager.h M +6 -2 plugins/extensions/resourcemanager/resourcemanager.cpp M +2 -0 plugins/extensions/resourcemanager/resourcemanager.h M +4 -22 plugins/extensions/resourcemanager/wdgdlgbundlemanager.ui http://commits.kde.org/krita/86cbc6cddad65b1e92e627e5970c480c6bae1fb4 I'm testing again this bug on Git~master ( compiled today ). The 'Edit' button was removed from the bundle resource manager and renamed to 'Create a new bundle from this bundle' but the feature is still broken. To trigger bug: =============== Create a little bundle: - Settings > Manage Resources, then 'Create New Bundle' button. - 'Type' list , select Brush Preset , and add two random brush presets to the 'Selected' Column. - Give a "Bundle Name" - Press Save Now we can select it, and try to "Create a new Bundle from this bundle" Result: ======= - The dialog is empty, the "...from this bundle" in the button label "Create a new Bundle from this bundle" doesn't work. Git commit 5e59048c3f39064e5a2eb586d3866ccfc88592c0 by Boudewijn Rempt. Committed on 24/01/2017 at 14:13. Pushed by rempt into branch 'master'. Editing bundles now seems to work; it will overwrite an existing bundle, though, not save a new one. Creating new bundles now also adds the bundle to the resource manager. M +11 -3 libs/ui/KisResourceBundle.cpp M +5 -5 libs/ui/KisResourceBundle.h M +9 -7 plugins/extensions/resourcemanager/dlg_bundle_manager.cpp M +53 -2 plugins/extensions/resourcemanager/dlg_create_bundle.cpp M +1 -0 plugins/extensions/resourcemanager/dlg_create_bundle.h M +16 -4 plugins/extensions/resourcemanager/resourcemanager.cpp M +2 -2 plugins/extensions/resourcemanager/resourcemanager.h M +17 -14 plugins/extensions/resourcemanager/wdgdlgbundlemanager.ui M +77 -90 plugins/extensions/resourcemanager/wdgdlgcreatebundle.ui https://commits.kde.org/krita/5e59048c3f39064e5a2eb586d3866ccfc88592c0 Git commit 7c8f66a20c04ef02d734426d5ce806d710636214 by Boudewijn Rempt. Committed on 24/01/2017 at 14:14. Pushed by rempt into branch 'krita/3.1'. Editing bundles now seems to work; it will overwrite an existing bundle, though, not save a new one. Creating new bundles now also adds the bundle to the resource manager. M +11 -3 libs/ui/KisResourceBundle.cpp M +5 -5 libs/ui/KisResourceBundle.h M +9 -7 plugins/extensions/resourcemanager/dlg_bundle_manager.cpp M +53 -2 plugins/extensions/resourcemanager/dlg_create_bundle.cpp M +1 -0 plugins/extensions/resourcemanager/dlg_create_bundle.h M +16 -4 plugins/extensions/resourcemanager/resourcemanager.cpp M +2 -2 plugins/extensions/resourcemanager/resourcemanager.h M +17 -14 plugins/extensions/resourcemanager/wdgdlgbundlemanager.ui M +77 -90 plugins/extensions/resourcemanager/wdgdlgcreatebundle.ui https://commits.kde.org/krita/7c8f66a20c04ef02d734426d5ce806d710636214 |
Hi, When creating a bundle with the current system [1] it's easy to forget to include a single resources. Fortunately, a 'Edit' button exist, and launching it present even a GUI that looks like it possible to add missing resources, or modify a bad description. The big issue is the 'Save' button : it does nothing. Consequences for the potential user : ================================ * He/She can't edit a already made bundle that took a lot of time. * He/She realise 'creating' the whole bundle must be redone, to correct a single issue. * He/She lost the time of editing it, or re-editing it ; entering another name, before seeing it's a unfinished part of Krita, a trap. [2] Proposal : ======== I would prefer no 'Edit' button at all on the GUI of 'Manage Resource' than this false hope. Especially for a release. This is frustrating and feels like untested material, for a development branch. That's why I note it as 'critical' on the bug-tracker. [1] Asking user to resolve brush-tip and pattern dependencies manually by selecting each preset one by one and visiting edit-brush panel for each of them and note on paper what brush are used by moving the mouse cursor over the list and wait the 'tooltip' with the name of the resources to appear. Then go to the 'Create bundle' windows ( un-resizable ) and browse a tiny list to find the good name one by one noted on the sheet of paper. [2] As a user, when it's not working, I often blame my usage first, and try different scenario.( Without spacing in the filename, without accent, etc... )