Bug 352117

Summary:	attach as tab should respect userid (or group targets by userid -- see comment 1)
Product:	[Plasma] kwin	Reporter:	pf
Component:	window-tabbing	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED INTENTIONAL
Severity:	wishlist
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Mageia RPMs
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	mockup of suggestion

Description pf 2015-09-01 19:37:46 UTC

KDE4 4.14.3 on Mageia5 
Linux prf 4.1.1 #1 SMP Sat Jul 4 18:15:00 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux

Reproducible: Always

Steps to Reproduce:
Running:
a) multiple windows of Firefox Nightly on userid1 (auto-grouped into one main window on desktop1)
b) one window of Firefox Nightly on userid2 (testing) on desktop3

While doing some Firefox Nightly testing, in one window of a), selected "Open tab in new window" which created a separate (detached) window owned by userid1.

Wanting to re-attach this window as part of my testing, selected "Attach as tab to..." and was presented with list.  As luck would have it, I managed to select the window in b).  Spent the next while trying to locate this tab in a) without success.


Actual Results:  
When I finally found that "missing" tab it was on desktop3 in a group window containing:
- Firefox Nightly 43.0a1 (2015-08-30) (owned by userid2)
- Firefox Nightly 43.0a1 (2015-08-31) (owned by userid1)
(different versions of FF Nightly) ^^


Expected Results:  
Although both userids exist in the same KDE4 login session (the 2nd via "ssh userid2@localhost"), shouldn't the userids be kept separate? Or only present choices on current desktop -- window to be attached can be moved first as required...?

Comment 1 pf 2015-09-01 23:44:27 UTC

Created attachment 94337 [details]
mockup of suggestion

This is a suggested enhancement to give user a better chance of finding the window to attach to as a tab.

Comment 2 Thomas Lübking 2015-09-03 13:40:35 UTC

On X11, this would require an extension of the NETWM protocol to expose the user ID on the window. Not sure about wayland?

There's however absolutely nothing* kwin could possibly do unilaterally in this regard, the client (firefox) would have to provide that information itfp.

That doesn't necessarily say WONTFIX, but it's currently not possible (and given the state of NETWM, it likely WONTFIX on X11 indeed)

*on a linux with weak (but common) security and for local clients only, we could check the owner of /proc/_NET_WM_PID - we however so far avoid kernel interviews.

Comment 3 Martin Flöser 2015-09-07 06:08:22 UTC

> Not sure about wayland?

On Wayland we have easy access to the uid and gid. So from that point of view it will be possible. The bigger issue is that on Wayland at least GTK is strongly pushing for client side deocration so at least the Firefox usecase seems to become impossible anyway.

Comment 4 Martin Flöser 2016-08-29 06:45:10 UTC

Unfortunately the rework in decorations in KWin 5 resulted in the window tabbing feature to be lost. We still want to bring this feature back, but after several versions it still hasn't emerged yet. Given that I think it is time to adjust the status of this bug report. The new implementation would be different anyway and it's questionable whether this report would still apply to it.