Bug 352110

Summary: Toolbox docker has huge icons after update to 2.9.7
Product: [Applications] krita Reporter: HPetrus <haigpetrus>
Component: DockersAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: federico.fieni, halla
Priority: NOR    
Version First Reported In: 2.9.7   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description HPetrus 2015-09-01 17:07:12 UTC
Toolbox has huge icons when starting up 2.9.7 whether from update or installed from scratch (from .deb).

Also, Toolbox doesn't appear as a docker option in the Settings > Dockers menu.

Deleting all Krita config files didn't seem to help (unless there's one I missed).

The giant icons cause general window geometry problems because of their giant size.

Reproducible: Always

Steps to Reproduce:
1.  Install/update Krita 2.9.7
2.  Start Krita
3.  Toolbox is gigantic

Actual Results:  
I get giant icons in the Toolbox.

Expected Results:  
Normal, standard, manageable icons that I've grown to know and love with Krita.
Comment 1 Halla Rempt 2015-09-01 18:00:27 UTC
Hm... What's your display's resolution? One of the changes is that the size of the toolbox is now determined by the resolution by default, and you can select a different size by right-clicking on the toolbox. I've tried to select reasonable sizes, but I might have been mistaken for high-res displays.
Comment 2 Halla Rempt 2015-09-01 18:09:44 UTC
Git commit c1738e37e06db279f340fb39791fa39a510d99da by Boudewijn Rempt.
Committed on 01/09/2015 at 18:09.
Pushed by rempt into branch 'calligra/2.9'.

Re-add the toolbox docker to the toolbox menu

M  +1    -2    krita/ui/KisMainWindow.cpp

http://commits.kde.org/calligra/c1738e37e06db279f340fb39791fa39a510d99da
Comment 3 Halla Rempt 2015-09-01 18:10:16 UTC
Git commit 6853bcd1320814afad489e2bf18468710baba29b by Boudewijn Rempt.
Committed on 01/09/2015 at 18:10.
Pushed by rempt into branch 'master'.

Re-add the toolbox docker to the toolbox menu

M  +1    -2    krita/ui/KisMainWindow.cpp

http://commits.kde.org/calligra/6853bcd1320814afad489e2bf18468710baba29b
Comment 4 HPetrus 2015-09-01 20:45:46 UTC
AH!  That did it.  Thanks, Boud.

My display resolution is 2560x1440 on this one.  The other machine is 
5K.  Both were wonky.  Didn't realize there was a right-click menu.


--Haig

On 09/01/2015 02:00 PM, Boudewijn Rempt wrote:
> https://bugs.kde.org/show_bug.cgi?id=352110
>
> Boudewijn Rempt <boud@valdyas.org> changed:
>
>             What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                   CC|                            |boud@valdyas.org
>
> --- Comment #1 from Boudewijn Rempt <boud@valdyas.org> ---
> Hm... What's your display's resolution? One of the changes is that the size of
> the toolbox is now determined by the resolution by default, and you can select
> a different size by right-clicking on the toolbox. I've tried to select
> reasonable sizes, but I might have been mistaken for high-res displays.
>
Comment 5 federico.fieni 2015-09-01 22:16:39 UTC
I had the same problem with the same screen resolution and I think that icons larger than 22x22 trigger that window misbehaviour (Ubuntu Gnome 14.04)
Comment 6 Halla Rempt 2015-09-02 08:44:29 UTC
Git commit 051f528665fc2bb4477cc8f2b159abaa3d36b036 by Boudewijn Rempt.
Committed on 02/09/2015 at 08:44.
Pushed by rempt into branch 'calligra/2.9'.
Related: bug 22

M  +1    -4    libs/widgets/KoToolBox.cpp

http://commits.kde.org/calligra/051f528665fc2bb4477cc8f2b159abaa3d36b036
Comment 7 Halla Rempt 2015-09-02 08:45:45 UTC
Okay, let's cap the default icon size to 22, but still allow people to choose bigger sizes if they want to. The right-click option will be mentioned in the release announcement -- these still aren't the final builds :-)
Comment 8 Halla Rempt 2015-09-02 09:05:32 UTC
Git commit ccfb59b1a1a3c5b1e7da4f7f618525a9d5e57648 by Boudewijn Rempt.
Committed on 02/09/2015 at 09:05.
Pushed by rempt into branch 'master'.
Related: bug 22

M  +1    -4    libs/widgets/KoToolBox.cpp

http://commits.kde.org/calligra/ccfb59b1a1a3c5b1e7da4f7f618525a9d5e57648
Comment 9 HPetrus 2015-09-02 12:24:12 UTC
Good to know.  I learned something new out of this with the right-click 
context menu on the Toolbox.  Very cool and convenient, rather than 
diving into tabbed settings.  Always a fan of context-sensitive menus.

On 09/02/2015 04:45 AM, Boudewijn Rempt wrote:
> https://bugs.kde.org/show_bug.cgi?id=352110
>
> --- Comment #7 from Boudewijn Rempt <boud@valdyas.org> ---
> Okay, let's cap the default icon size to 22, but still allow people to choose
> bigger sizes if they want to. The right-click option will be mentioned in the
> release announcement -- these still aren't the final builds :-)
>