| Summary: | Dolphin git plugin displays its menu wrapped into <application> | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | SeeLook <seelook> |
| Component: | plugins: git | Assignee: | Sebastian Dörner <sebastian> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dolphin-bugs-null, thepouar |
| Priority: | NOR | ||
| Version: | 16.12.2 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/dolphin-plugins/3bb5917d21b1de8a84fc34a1cdfc23e9a20c94a2 | Version Fixed In: | 15.08.1 |
| Sentry Crash Report: | |||
is "Git Add" broken too or is it just me? Yes, I have it broken too but a reason is rather different so it might be another bug report. I put fixes for both bugs to review: https://git.reviewboard.kde.org/r/125052/ https://git.reviewboard.kde.org/r/125054/ Git commit 3bb5917d21b1de8a84fc34a1cdfc23e9a20c94a2 by Emmanuel Pescosta, on behalf of Tomasz Bojczuk. Committed on 06/09/2015 at 15:09. Pushed by emmanuelp into branch 'Applications/15.08'. Fixed Dolphin context menu entries inside git repos All occurences of i18nc were changed in xi18nd to properly pharse <application> tags REVIEW: 125052 FIXED-IN: 15.08.1 M +29 -29 git/fileviewgitplugin.cpp http://commits.kde.org/dolphin-plugins/3bb5917d21b1de8a84fc34a1cdfc23e9a20c94a2 |
Context menu of Dolphin in any git repository displays any action of git wrapped by: <application></application> like: <application>add</application> <application>pull</application> Reproducible: Always Steps to Reproduce: Just open context menu in git repo I had the same problem with mercurial plugin during porting it to KF5. The solution was to change: m_addAction->setText(i18nc("@action:inmenu", "<application>Git</application> Add")); into m_addAction->setText(xi18nd("@action:inmenu", "<application>Git</application> Add")); In spare time I will send a patch :-)