Bug 351752

Summary:	Licensing issues in kdepimlibs 15.08.0
Product:	[Applications] kdepimlibs	Reporter:	Christophe Marin <christophe>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aj, lbeltrame, vkrause
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/kdepimlibs/a7831bbdfdf9896eb9518bca1abb94185d81bdac	Version Fixed In:
Sentry Crash Report:
Bug Depends on:
Bug Blocks:	346175

Description Christophe Marin 2015-08-25 12:41:43 UTC

Noticed by the openSUSE legal team : 

« There are numerous GPL-2.0 matches in the source code. Are you sure this should be LGPL-2.1+? What about e.g. kdepimlibs-15.08.0/akonadi/src/core/newmailnotifierattribute.cpp (just one example)? »

--

Running licensecheck and removing the LGPL-2.1+ compatible files leads to this :
akonadi/src/core/notificationbus_p.cpp: GPL
akonadi/src/core/notificationbus_p.h: GPL

akonadi/src/core/qtest_akonadi.h: LGPL (v2)
akonadi/src/xml/autotests/collectiontest.h: LGPL (v2)
kioslave/src/nntp/nntp.cpp: LGPL (v2)
kioslave/src/nntp/nntp.h: LGPL (v2)
kioslave/src/sieve/sieve.cpp: GPL (v2)

kioslave/src/ldap/kldap_debug.cpp: *No copyright* UNKNOWN
kioslave/src/ldap/kldap_debug.h: *No copyright* UNKNOWN

akonadi/src/core/newmailnotifierattribute.cpp: GPL (v2)
akonadi/src/core/newmailnotifierattribute.h: GPL (v2)
akonadi/src/core/pop3resourceattribute.cpp: GPL (v2)
akonadi/src/core/pop3resourceattribute.h: GPL (v2)
akonadi/src/widgets/tagselectwidget.cpp: GPL (v2)
akonadi/src/widgets/tagselectwidget.h: GPL (v2)
kioslave/src/sieve/sieve.h: GPL (v2)
kioslave/src/smtp/capabilities.cpp: GPL (v2)
kioslave/src/smtp/capabilities.h: GPL (v2)
kioslave/src/smtp/command.cpp: GPL (v2)
kioslave/src/smtp/command.h: GPL (v2)
kioslave/src/smtp/request.cpp: GPL (v2)
kioslave/src/smtp/request.h: GPL (v2)
kioslave/src/smtp/response.cpp: GPL (v2)
kioslave/src/smtp/response.h: GPL (v2)
kioslave/src/smtp/transactionstate.cpp: GPL (v2)
kioslave/src/smtp/transactionstate.h: GPL (v2)

tests :
kioslave/src/smtp/tests/test_capabilities.cpp: *No copyright* UNKNOWN
kioslave/src/smtp/tests/test_commands.cpp: *No copyright* UNKNOWN
kioslave/src/smtp/tests/test_headergeneration.cpp: *No copyright* UNKNOWN
kioslave/src/smtp/tests/test_responseparser.cpp: *No copyright* UNKNOWN

akonadi/autotests/collectionmodifytest.cpp: GPL

akonadi/autotests/newmailnotifierattributetest.cpp: GPL (v2)
akonadi/autotests/newmailnotifierattributetest.h: GPL (v2)
akonadi/autotests/pop3resourceattributetest.cpp: GPL (v2)
akonadi/autotests/pop3resourceattributetest.h: GPL (v2)
akonadi/autotests/tagselectwidgettest.cpp: GPL (v2)
akonadi/autotests/tagselectwidgettest.h: GPL (v2)
kioslave/src/smtp/tests/interactivesmtpserver.cpp: GPL (v2)
kioslave/src/smtp/tests/interactivesmtpserver.h: GPL (v2)
kioslave/src/smtp/tests/requesttest.cpp: GPL (v2)
kioslave/src/smtp/tests/requesttest.h: GPL (v2)

akonadi/autotests/fakeakonadiservercommand.cpp: GPL (v2 or later)
akonadi/autotests/fakeakonadiservercommand.h: GPL (v2 or later)
akonadi/autotests/fakeserverdata.cpp: GPL (v2 or later)
akonadi/autotests/fakeserverdata.h: GPL (v2 or later)

Comment 1 Volker Krause 2015-09-25 20:56:29 UTC

There's lots of tests (not packaged) and kioslave (quasi separate executables) code in that list, the relevant bits of actually wrongly licensed library code seem to be:

akonadi/src/core/notificationbus_p.* (Dan)
akonadi/src/core/newmailnotifierattribute.* (Laurent)
akonadi/src/core/pop3resourceattribute.* (Laurent)
akonadi/src/widgets/tagselectwidget.* (Christian)

Comment 2 Volker Krause 2015-09-26 09:47:12 UTC

Git commit 762d4beae2d761b76c3eb8212523c64ddb2ff4c0 by Volker Krause.
Committed on 26/09/2015 at 09:46.
Pushed by vkrause into branch 'Applications/15.08'.

Relicense two accidentally GPLed files in libakonadi.

Approved by Dan of course.

M  +17   -19   akonadi/src/core/notificationbus_p.cpp
M  +17   -19   akonadi/src/core/notificationbus_p.h

http://commits.kde.org/kdepimlibs/762d4beae2d761b76c3eb8212523c64ddb2ff4c0

Comment 3 Laurent Montel 2015-09-27 06:56:48 UTC

Git commit 279091d2ac68a65f15b9240d2bbccddd9956acfc by Montel Laurent.
Committed on 27/09/2015 at 06:56.
Pushed by mlaurent into branch 'Applications/15.08'.

Fix license

M  +16   -14   akonadi/src/core/newmailnotifierattribute.cpp
M  +16   -14   akonadi/src/core/newmailnotifierattribute.h
M  +13   -11   akonadi/src/core/pop3resourceattribute.cpp
M  +16   -14   akonadi/src/core/pop3resourceattribute.h

http://commits.kde.org/kdepimlibs/279091d2ac68a65f15b9240d2bbccddd9956acfc

Comment 4 Volker Krause 2015-10-17 10:25:41 UTC

Git commit a7831bbdfdf9896eb9518bca1abb94185d81bdac by Volker Krause.
Committed on 17/10/2015 at 10:25.
Pushed by vkrause into branch 'Applications/15.08'.

Fix license, this needs to be LGPL.

Approved by Laurent.

M  +15   -13   akonadi/src/widgets/tagselectwidget.cpp
M  +15   -13   akonadi/src/widgets/tagselectwidget.h

http://commits.kde.org/kdepimlibs/a7831bbdfdf9896eb9518bca1abb94185d81bdac