| Summary: | Should show a warning dialog if trying to open WM settings and kcmshell is not installed | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Unknown <null> |
| Component: | core | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED NOT A BUG | ||
| Severity: | wishlist | ||
| Priority: | NOR | ||
| Version First Reported In: | 5.3.2 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
Unknown
2015-08-09 11:03:06 UTC
The code in question got recently changed, see: http://quickgit.kde.org/?p=kwin.git&a=blobdiff&h=562255d85cd67f46cbf8b1fc0ed4bfe3c6ee0a85&hp=428d854665d5f2ecbcb08df7f351c80784f7890e&hb=f6458fa1e8e92fdf16a1acc961703d229894454c&f=useractions.cpp It still doesn't show a warning, but we could emit a KNotification - or as done in TabBox use kdialog. Unfortunately I doubt we can just assume that KNotification or KDialog are installed and useable, either. Maybe the best idea is to make kcmshell5 a runtime dependency which is checked with cmake and then assume that distros have dependencies set up correctly? Down the line, maybe on our side in LXQt we'll make a standalone kwin settings app. I don't want to suggest something way overengineered as a solution, so here's a thought: - Change the kcmshell5 invocation to a named shell script. "kwin-settings" or something similar. - In the script, check whether kcmshell5 exists in the path/is invocable/whatever. If it's not, you can send a dialog or a notification from the shell script fairly reliably. - Down the line, more binary checks can be added. Performance hit should be insignificant and it avoids an unnecessary dependency. Thoughts? If the thought is about better integration into LXQt we might want to rethink it completely. Maybe make it an env variable or a setting. After all I think what we are looking for is for a desktop environment to easily default configure all of KWin. It's not just the settings applications, but also things like: * tabbox (lnf package) * window decoration * overrides for various currently Plasma styled QtQuick elements * etc. etc. I think that needs some musing about the easiest way to get KWin there. I don't think that showing a notification is going to help. Notifications don't seem like the right tool here. If a desktop environment or a distribution don't include necessary tools to make kwin work properly, showing notifications in this case is not really a great UX and the user should not be expected to install more packages based on notifications. That being said, if there's still interest in such a thing, please submit us patches and we can talk more in detail about it. |