Bug 351009

Summary: Filter bug using Gray Scale Image using Krita 2.9.6.3 (git 30d614e)
Product: [Applications] krita Reporter: Leonardo Azenha <azenha.leonardo>
Component: FiltersAssignee: Thorsten Zachmann <mo>
Status: RESOLVED FIXED    
Severity: major CC: halla, smjert
Priority: NOR Keywords: release_blocker
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
URL: http://i.imgur.com/QMkpduA.png?1
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: test file

Description Leonardo Azenha 2015-08-05 19:08:02 UTC 
After I changed the color profile to gray scale, and created a new layer to paint, I tried to change some values using the HSV Filter, the occurs the bug, this not occurs on RGB layers.

Reproducible: Always

Steps to Reproduce:
1. Open a file with a colorspace RGB
2. Change to gray scale
3. Create a new layer, notice the palette changes to Grays
4. Paint something
5. Use Filter > Adjust > HSV Adjustment

Actual Results:  
The selected gray scale layer glitch, if "Cancel" it goes back to normal, if "Ok" the image stays 'buged'. Selecting "Preview" does not change the results.

Expected Results:  
Be able to change the lightness without problem.

On the same file, the RGB layers does not change to gray, and do not show the bug.
Comment 1 Leonardo Azenha 2015-08-05 19:42:30 UTC 
*** Bug 351010 has been marked as a duplicate of this bug. ***
Comment 2 Leonardo Azenha 2015-08-05 19:49:30 UTC 
The same results with the filters:
Color Balance
http://i.imgur.com/QTJuX2c.png

Desaturate
http://i.imgur.com/tAUep7P.png

Can replicate with anoter file created using only grayscale colorspace.
Comment 3 Halla Rempt 2015-08-06 08:11:53 UTC 
Hi Leonardo,

Thanks for your report. I can confirm the issue and it's a regression since Krita 2.8. I'll look into it right now.
Comment 4 Halla Rempt 2015-08-06 09:42:05 UTC 
The regression appeared in:

c6978280553bf51643265fb3acd969879fd006d3 is the first bad commit
commit c6978280553bf51643265fb3acd969879fd006d3
Author: Thorsten Zachmann <t.zachmann@zagge.de>
Date:   Sat Jul 4 05:53:57 2015 +0200

    Use the KisColorTransformationConfiguration
    
    Only create the transformation matrix once and reuse it in every patch/thread.
    Use the KisColorTransformation also in factoryConfiguration method.
Comment 5 Halla Rempt 2015-08-06 09:56:36 UTC 
Created attachment 93914 [details]
test file

No need to do conversions, just load this file in krita and apply open the hsv filter dialog.
Comment 6 Halla Rempt 2015-08-06 10:30:47 UTC 
Git commit ae00bf64f3e2bf5ced79cf06e3f013c460c854ae by Boudewijn Rempt.
Committed on 06/08/2015 at 09:55.
Pushed by rempt into branch 'calligra/2.9'.

Revert "Use the KisColorTransformationConfiguration"

This reverts commit c6978280553bf51643265fb3acd969879fd006d3.

M  +3    -3    krita/plugins/filters/colorsfilters/kis_color_balance_filter.cpp
M  +3    -3    krita/plugins/filters/colorsfilters/kis_desaturate_filter.cpp
M  +3    -3    krita/plugins/filters/colorsfilters/kis_hsv_adjustment_filter.cpp
M  +2    -2    krita/plugins/filters/dodgeburn/DodgeBurn.cpp
M  +2    -2    krita/plugins/filters/indexcolors/indexcolors.cpp
M  +2    -2    krita/plugins/filters/posterize/posterize.cpp

http://commits.kde.org/calligra/ae00bf64f3e2bf5ced79cf06e3f013c460c854ae
Comment 7 Stefano Bonicatti 2015-08-14 20:11:32 UTC 
I tested this on Windows 7 and after the patch boud did is not happening anymore.