Bug 350885

Summary: Grouping images via the thumbbar is possible, but they disappear in digikam [patch]
Product: [Applications] digikam Reporter: Gus Gustafson <efelthauser>
Component: Albums-ItemGroupAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, efelthauser, metzpinguin
Priority: NOR    
Version: 4.7.0   
Target Milestone: ---   
Platform: Kubuntu   
OS: Linux   
Latest Commit: http://commits.kde.org/digikam/503af86e461e61a8dda974e4f85bb5f340044863 Version Fixed In: 4.13.0
Sentry Crash Report:
Attachments: imagedragdrop.patch

Description Gus Gustafson 2015-08-02 14:41:59 UTC 
The interface allows you to drop one image onto another in the Thumbbar when you are previewing images to group them. However, after you have done it this way, it disappears in digikam. If you right-click on the image, you do not get a "group" option in the list to ungroup them. The missing image is still viewable via the system file explorer, you just can't get to it in digikam anymore...

Reproducible: Always

Steps to Reproduce:
1. Enable thumbbar (Settings > Show thumbbar)
2. Open Preview (F3)
3. Drag one image on top of another to "group"
4. Try to ungroup...Impossible

Actual Results:  
Image cannot be ungrouped.

Expected Results:  
Should be able to ungroup image.
Comment 1 Maik Qualmann 2015-08-02 21:08:11 UTC 
I can not reproduce the issue with digiKam 4.12.0. It is right, in the thumbar images can be grouped. The ungrouping is possible in the icon view.

Maik
Comment 2 caulier.gilles 2015-08-14 08:54:54 UTC 
Maik,

It's a question ?

"It is right, in the thumbbar images can be grouped. The ungrouping is possible in the icon view."

If we can group items from thumbbar but not ungroup it at the same place this can be problematic. I vote to disable grouping function for thumbbar for the moment.

Gilles
Comment 3 Gus Gustafson 2015-08-14 15:14:40 UTC 
It sounds like Maik does not find the problem. Maybe something has been fixed between my version (4.7.0) and his version 4.12.0? (I am using version in Kubuntu 15.04 so cannot test the latest.) If the problem is not occurring in 4.12.0, maybe the function does not need to be disabled?
Comment 4 Gus Gustafson 2015-08-14 15:17:49 UTC 
Although, it is true--if we can group in thumbbar, ungroup also via thumbbar would be best.
Sorry for double comment.
Comment 5 Maik Qualmann 2015-08-14 19:54:48 UTC 
OK, for a new test now, I can actually see a problem. The grouping is performed not now under the picture that has been selected, but depending on the album some pictures in front or behind. I will check it.

Maik
Comment 6 Maik Qualmann 2015-08-30 18:32:01 UTC 
Created attachment 94288 [details]
imagedragdrop.patch

The thumbbar has an addition NoDuplicatesImageFilterModel. Thus, the index is no longer always syncron with the icon view. Depending on the album can the grouping work correctly using drag & drop, but need not be. The grouping will be executed under a different image in the album. This patch fixes the grouping in the thumbbar.

Maik
Comment 7 caulier.gilles 2015-08-30 21:14:25 UTC 
tested and work fine here...

Gilles
Comment 8 Maik Qualmann 2015-08-31 06:10:06 UTC 
Git commit 503af86e461e61a8dda974e4f85bb5f340044863 by Maik Qualmann.
Committed on 31/08/2015 at 05:56.
Pushed by mqualmann into branch 'master'.

apply patch #94288 to the correct ImageInfo at a drag and drop action to obtain in the thumbbar
FIXED-IN: 4.13.0

M  +2    -2    NEWS
M  +11   -1    app/dragdrop/imagedragdrop.cpp

http://commits.kde.org/digikam/503af86e461e61a8dda974e4f85bb5f340044863
Comment 9 caulier.gilles 2015-08-31 06:55:26 UTC 
Git commit 64626707d61d543a4c4d879a53a390bdfac0c91c by Gilles Caulier.
Committed on 31/08/2015 at 06:54.
Pushed by cgilles into branch 'frameworks'.

backport commit #503af86e461e61a8dda974e4f85bb5f340044863 from git/master to frameworks branch

M  +11   -1    app/dragdrop/imagedragdrop.cpp

http://commits.kde.org/digikam/64626707d61d543a4c4d879a53a390bdfac0c91c