Summary: | Plasma Crash When Editing Dashboard | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | John <jtmackoy> |
Component: | general | Assignee: | David Edmundson <kde> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | bhush94, plasma-bugs |
Priority: | NOR | Keywords: | drkonqi |
Version: | 5.3.2 | ||
Target Milestone: | 1.0 | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/plasma-desktop/7a514de428ef1da5fa14dc004775c21b3b710e7d | Version Fixed In: | |
Sentry Crash Report: |
Description
John
2015-08-01 17:46:18 UTC
>#47 0x00007f76771ffc5d in QDialog::exec() () from /lib64/libQt5Widgets.so.5
and here's our problem.
execs from the main thread in QML are bad.
I'll see if I can rework our KIconDialog wrapper
Git commit 7a514de428ef1da5fa14dc004775c21b3b710e7d by David Edmundson. Committed on 02/08/2015 at 22:32. Pushed by davidedmundson into branch 'master'. Use the better implementation of IconDialog For some reason we have two IconDialog's exported to QML. One in KDeclarative, one in Plasma-Frameworks/platformcomponents. The one in plasmacomponents performs an exec() in the main thread from QML which is a very bad idea. the one in kdeclarative is good. REVIEW: 124580 M +4 -6 desktoppackage/contents/activitymanager/ActivityCreationDialog.qml http://commits.kde.org/plasma-desktop/7a514de428ef1da5fa14dc004775c21b3b710e7d |