Bug 350836

Summary:	change avatar doesn't work if you click ok
Product:	[Unmaintained] user-manager	Reporter:	Jonathan Riddell <jr>
Component:	kcontrol module	Assignee:	Jonathan Riddell <jr>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/user-manager/826e41429917f6c1534e84e8b7821b8b53675910	Version Fixed/Implemented In:	5.8.7
Sentry Crash Report:

Description Jonathan Riddell 2015-07-31 20:48:58 UTC

changing avatar doesn't get saved if you click ok
it does work if you click apply
this is because the kio::copyJob needs to finish before it does anything, but it doesn't get the finished signal if you click ok


Reproducible: Always

Comment 1 Elvis Angelaccio 2017-05-09 20:52:40 UTC

Git commit 826e41429917f6c1534e84e8b7821b8b53675910 by Elvis Angelaccio.
Committed on 08/05/2017 at 21:20.
Pushed by elvisangelaccio into branch 'Plasma/5.8'.

Make sure the new avatar is always saved

Summary:
The KIO job needs to be run synchronously, otherwise the KCM might be
deleted before the job finished. This happens when closing the KCM
module with the Ok button, or when closing the System Settings window
and clicking Apply.
FIXED-IN: 5.8.7

Test Plan: Change avatar from System Settings, then close System Settings and click Apply.

Reviewers: #plasma, jriddell

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D5779

M  +2    -1    src/accountinfo.cpp

https://commits.kde.org/user-manager/826e41429917f6c1534e84e8b7821b8b53675910