Bug 350803

Summary:	"Anti-Aliased" on/off toggle gone for some selection tools.
Product:	[Applications] krita	Reporter:	William Thorup <7achoneus>
Component:	Tools	Assignee:	Michael <miabraha>
Status:	RESOLVED FIXED
Severity:	normal	CC:	griffinvalley, miabraha
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	http://commits.kde.org/calligra/51773e09feae4188816389cc47e34d26d1028119	Version Fixed/Implemented In:
Sentry Crash Report:

Description William Thorup 2015-07-30 20:55:23 UTC

Recently upgraded from Krita 2.9.5 64bit to 2.9.6 64bit  Windows 64 bit, and noticed that the toggle for "Anti-Aliased" is missing from the "Tool Options" docker for several of the the selection tools.  Specifically the Elliptical Selection, Polygonal Selection, and the Outline Selection tool.

This post in this thread mentioned that it might have been caused by the selection modifier patch refactor. https://forum.kde.org/viewtopic.php?f=288&t=127357#p338899

I will see if I can confirm this for Linux as well when I get the time.

Reproducible: Always

Steps to Reproduce:
1.Install Krita 2.9.5.1
2.Update to Krita 2.9.6.3
3.choose one of the following selection tools: Elliptical Selection, Polygonal Selection, Outline Selection

Actual Results:  
"Anti-aliased" toggle gone.

Expected Results:  
"Anti-Aliased" toggle available and usable.

Comment 1 Michael 2015-08-01 03:53:01 UTC

Looking into this.

Comment 2 wolthera 2015-08-02 13:35:41 UTC

Mike, I am setting this to assigned to you then.

Comment 3 Michael 2015-08-03 21:42:50 UTC

Patch in Phab: https://phabricator.kde.org/D232

Comment 4 Michael 2015-08-04 21:12:52 UTC

Git commit 51773e09feae4188816389cc47e34d26d1028119 by Michael Abrahams.
Committed on 04/08/2015 at 21:12.
Pushed by abrahams into branch 'calligra/2.9'.

Re-enable antialias for selection tools.

Summary:
Removed a call to  "disable antialias option" which was applied to all
tools during the refactor.  Enable AA for the select path tool as well.

Reviewers: rempt, dkazakov

Differential Revision: https://phabricator.kde.org/D232

M  +1    -1    krita/plugins/tools/selectiontools/kis_tool_select_outline.cc
M  +1    -1    krita/plugins/tools/selectiontools/kis_tool_select_path.cc
M  +0    -1    krita/ui/tool/kis_tool_select_base.h

http://commits.kde.org/calligra/51773e09feae4188816389cc47e34d26d1028119