Bug 350696

Summary:	git master 2015-07-28 - unable to import multiple files with dates in their names.
Product:	[Applications] kdenlive	Reporter:	Evert Vorster <evorster>
Component:	User Interface & Miscellaneous	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	http://commits.kde.org/kio/b684fa02ec7bd6b791682aaeb76398ce2cc87b03	Version Fixed In:
Sentry Crash Report:

Description Evert Vorster 2015-07-28 08:34:03 UTC

Since the date sort function is missing in kdenlive, I decided to write a little script that renames the file and adds ISO format mtime to the front of the filename. 
When I tried to import the files all at once, kdenlive popped up an error message, saying that the selection contained a directory, and it did not. 

Single files import fine, but when I select just two files, I get the error message. 
What really should happen is that kdenlive should be able to handle directories. Obviously, if a directory is selected, the editor should import everything in that directory that it knows how to import. I use directories to sort year/month/event/camera, and when importing it would be much easier to just select the event directory, and have kdenlive import all the video clips in the subdirectories. 

Reproducible: Always

Steps to Reproduce:
1. have files named in the following manner:
2014-01-19_20:42:10-MVI_2235.MOV
2014-02-07_23:06:20-MVI_2237.MOV
2014-02-20_15:45:18-MVI_2488.MOV
2014-02-26_14:44:54-MVI_2489.MOV
2014-02-26_14:54:16-MVI_2490.MOV
2014-03-01_21:56:18-MVI_2491.MOV
2014-03-07_21:36:18-MVI_2492.MOV
2. Select more than one of these files, and try to import into kdenlive
3. Read error message complaining about a directory. 

Actual Results:  
Error message

Expected Results:  
Imported video files

Comment 1 Evert Vorster 2015-07-28 08:43:59 UTC

I am able to import multiple files by selecting them in Dolphin and just dragging them into the Project Bin

Comment 2 Jean-Baptiste Mardelle 2015-07-28 09:20:53 UTC

This is a KDE libs issue. The bug is caused by having a semi-colon (":") in the file names. A fix is being prepared, but this will require a KDE Frameworks update, nothing we can do on the Kdenlive side. However, I am leaving it open since the Folder opening stuff is interesting, will work on dropping a folder.

Comment 3 Jean-Baptiste Mardelle 2015-08-04 21:46:56 UTC

Dropping a folder into Kdenlive's bin should work now if you want to test it.

Comment 4 Evert Vorster 2015-08-04 23:32:20 UTC

I can confirm that dragging a folder into the project bin from Dolphin works, now. 
I can even drag a folder from kdenlive's internal file open dialog on to the project bin, and that appears to work as well. I have not done too much testing on it. 

However, kdenlive still complains if a directory and some files are selected and then clicked on the OK button. If I just select a directory and then click on the OK button, the file add dialog just opens the folder, rather than load all the clips in the folder to the project bin.

Comment 5 Evert Vorster 2015-09-04 12:50:04 UTC

Can you point me to the bug report for the kdelibs issue on the filenames?

This is a pretty silly limitation to have

Comment 6 Evert Vorster 2015-09-04 13:19:08 UTC

Hi there... 

Looking at this thing again. 
When a folder is highlighted, and the OK button clicked, the folder should be loaded, not opened. 

Funnily enough, as I was preparing a video to show this, I discovered another bug related to how we handle folders. 
Files automatically added to the project, also ends up in a folder. For instance, the file created by the capture ended up in one of the folders I dragged in, instead of the root of the Project Bin
Video: http://youtu.be/ufTcrJXPTVk

Comment 7 Jean-Baptiste Mardelle 2015-09-04 20:31:38 UTC

After looking in the bugtracker, seems like this issue was not reported. I created a patch proposal to fix the issue: https://git.reviewboard.kde.org/r/125051/

Comment 8 David Faure 2015-09-07 07:48:04 UTC

Git commit b684fa02ec7bd6b791682aaeb76398ce2cc87b03 by David Faure.
Committed on 07/09/2015 at 07:47.
Pushed by dfaure into branch 'master'.

Fix path/URL confusion again in this code.
Change-Id: I65d623220b295c8606fe375fb4659554dd50ac2d
REVIEW: 125051

M  +3    -5    src/filewidgets/kfilewidget.cpp

http://commits.kde.org/kio/b684fa02ec7bd6b791682aaeb76398ce2cc87b03