| Summary: | The composers cancel button should indicate that this will either save or drop | ||
|---|---|---|---|
| Product: | [Unmaintained] trojita | Reporter: | Thomas Lübking <thomas.luebking> |
| Component: | Desktop GUI | Assignee: | Trojita default assignee <trojita-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | spencerbrown991 |
| Priority: | NOR | ||
| Version: | git | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Thomas Lübking
2015-07-26 14:32:18 UTC
Suggestions welcome. I'm unfortunately familiar with what it does, so I cannot really evaluate how big the need for a change is, nor what that change should look like :(. Bug is meant as a reminder for myself - just noticed the ambiguity/problem. Basically, whenever we enter the "got to save" state, one would alter the text from "cancel" to "Drop or Save Draft" or such. One could have two buttons (save initially disabled) but that just adds more clutter and I'd like to keep the general "ask on close" protection. Hi. I've set the composer's cancel button's text to change from "Cancel" to "Save/Ignore Changes" when the composer state changes to SaveRequired. (i.e. in the Composer::MessageUpdated slot) I did run into a minor issue: the slot is called as soon as the compositor object is created, in the slotUpdateSignature function. To solve this, i just set the button's text back to "Cancel" after the slotUpdateSignature function in the ComposeWidget Constructor. Now it works perfectly. gerrit patch: https://gerrit.vesnicky.cesnet.cz/r/#/c/842/ Git commit 2fdfc40d24acc198644f104b35cdbdd13e982a95 by Spencer Brown. Committed on 01/12/2016 at 14:21. Pushed by gerrit into branch 'master'. Fixes ambiguities with cancel button in composer dialog and changes state management Change-Id: Ibb9e62aa3c6f119c73cde52a1f356ddac736fc81 M +50 -14 src/Gui/ComposeWidget.cpp M +8 -9 src/Gui/ComposeWidget.h https://commits.kde.org/trojita/2fdfc40d24acc198644f104b35cdbdd13e982a95 Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version? If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you! |