Bug 350628

Summary:	Changing color using the Advanced color selector resets alternative brush size
Product:	[Applications] krita	Reporter:	sqdqsddd
Component:	Usability	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla, nicholaslapointe8
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Microsoft Windows
Latest Commit:	http://commits.kde.org/krita/6752dbe794afb8effba426e5c376b7eb79976ef0	Version Fixed In:
Sentry Crash Report:

Description sqdqsddd 2015-07-26 13:39:53 UTC

I use alternative brush size for the eraser (with the option "eraser switch size").
when I pick another color using the advanced color selector in eraser mode, both the eraser and brush end up being the same size.

Reproducible: Always

Steps to Reproduce:
1.enable eraser switch size and set different size for brush and eraser
2.activate eraser mode in brush tool
3.pick any color in the advanced color selector
4. disabled the eraser mode

Actual Results:  
brush and eraser are the same size

Expected Results:  
brush and eraser should have different sizes

using W7, Krita 2.9.6

Comment 1 Halla Rempt 2015-08-07 11:28:41 UTC

Hi!

Thanks for your report. I can confirm, and it's more subtle even: setting the color appears already to switch off the eraser mode, even though the toolbar doesn't reflect that.

Comment 2 Nicholas LaPointe 2015-11-15 21:11:22 UTC

Line numbers given for calligra/2.9 a60bf1f version of /krita/ui/kis_paintop_box.cc

On line 412, sigFGColorChanged() is connected to slotUnsetEraseMode(). Removing this line fixes the bug, but I'm too unfamiliar with the code to know if this causes any regressions.

Additionally, slotUnsetEraseMode() only calls updateCompositeOp(). slotToggleEraseMode() appears to be the sole function responsible for calling toggleHighlightedButton(m_eraseModeButton) (line 881), which I imagine is why the toolbar icon remained highlighted (the "checked" status of the button still changed with this bug, though).

Comment 3 Sven Langkamp 2016-03-24 10:58:39 UTC

Git commit 6752dbe794afb8effba426e5c376b7eb79976ef0 by Sven Langkamp.
Committed on 24/03/2016 at 10:58.
Pushed by langkamp into branch 'master'.

Better way to unset the erase mode. This correctly updates the brush size if the eraser brush size option is enabled

M  +1    -1    libs/ui/kis_paintop_box.cc

http://commits.kde.org/krita/6752dbe794afb8effba426e5c376b7eb79976ef0