| Summary: | Default icon size too small | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Mircea Kitsune <sonichedgehog_hyperblast00> |
| Component: | view-engine: icons mode | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | andreas_k, nate, sonichedgehog_hyperblast00 |
| Priority: | NOR | ||
| Version: | 16.12.2 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/dolphin/bebcf035d264410c943e7bad861628c1b14dd1f2 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Mircea Kitsune
2015-07-14 14:33:41 UTC
Hi, 32px mimetype icons are added at the last plasma 5.4 release cause 32px look bad. so now breeze look also good with 32px mimetype icons. https://github.com/NitruxSA/breeze-icon-theme/tree/master/Breeze/mimetypes/32 in my point of view the bug can be closed. the 32px icons are included in breeze. In my opinion, the problem isn't whether icons are included... from what I remember they were supposed to be vectorial anyway. 32x is just too small... making it both a bit harder to click and find something, as well as looking ugly on modern monitors (1080p). Further more, x32 and x48 don't appear to have a great difference in icon spacing (at least horizontally), so this doesn't reduce too much space in the window either. They should depend on the DPI (*any* fixed value is to be a problem) "Ugly" should however be no consideration at all - just use an icon theme that's not "ugly". Dolphin is a file browser and no showcase for icon themes. Personal settings: 32/64 (In reply to Thomas Lübking from comment #4) I'm not saying Dolphin is supposed to be an icon showcase. I'm only pointing out that a good overall default appearance is also important, and the small icons tend to somewhat harm that. Larger icons also means it's easier to click on them more quickly, important on large displays. Windows Explorer has icons of about the same size I'm suggesting by default, sometimes even larger. I'm not implying we need to copy Windows of course, but they likely had a good reason. http://cdn.ghacks.net/wp-content/uploads/2014/10/windows-explorer-home.jpg In my point of view I would choose the 64px icons for standard icon size. why that big: - 32px is near toolbar icon size (22px) and the focus should be the files and folders - to have an good overview the maximum files and folders would be less than 20 so the standard icon size should focus on the standard folder structure not on having 50 - 100 files. I agree. Today's screens give us a lot more wiggle room, and this is user-changeable, after all. I'll see if I can work up a patch. To this day I continue using 48px for non-preview and 64px for preview. Anything less looks rather weird to me on a >= 1080p monitor, and kinda reminds me of ancient computers to be honest. Personally I continue to support these as the default sizes for icon view mode, which I find looks both more modern and more readable. I have a patch going through the review process that resolves this issue: https://phabricator.kde.org/D7440 My patch turns on previews by default, and turning on previews doubles the icon size, effectively making the default size 64 pixels. Git commit bebcf035d264410c943e7bad861628c1b14dd1f2 by Nathaniel Graham. Committed on 16/11/2017 at 02:49. Pushed by ngraham into branch 'master'. Turn on Dolphin icon previews by default Summary: Related: bug 338492 By default, turn on all preview plugins and turn on previews themselves. Depends on D8347 Test Plan: Tested this change in an up-to-date KDE Neon: removed the existing dolphinrc file, deployed Dolphin with the change, and observed that previews are now turned on for all file types for which a plugin exists except for text files, which are in the blacklist because they're mostly useless at nearly all icon sizes (still available in case people want them, though). Here's how Dolphin's main window looks by default now in KDE Neon: {F5441184} (You may notice that there are no previews for the video files; that's because Neon doesn't ship with any plugins for them, so that would be expected at this point) And here is how the Settings > General > Preview window looks like now by default: {F5435391} Reviewers: #dolphin, #vdg, markg, abetts, dfaure, aseigo, elvisangelaccio Reviewed By: #vdg, abetts, dfaure, elvisangelaccio Subscribers: abetts, cfeck, andreaska, emmanuelp, andreask, markg, broulik, anthonyfieroni, davidedmundson, ltoscano, dfaure, elvisangelaccio, #konqueror Tags: #dolphin Differential Revision: https://phabricator.kde.org/D7440 M +1 -1 CMakeLists.txt M +4 -4 src/kitemviews/kfileitemmodelrolesupdater.cpp M +1 -1 src/settings/dolphin_directoryviewpropertysettings.kcfg M +6 -6 src/settings/general/previewssettingspage.cpp M +6 -5 src/views/dolphinitemlistview.cpp https://commits.kde.org/dolphin/bebcf035d264410c943e7bad861628c1b14dd1f2 |
