Bug 350115

Summary:	"Create bundle" tool sometimes creates invalid bundles
Product:	[Applications] krita	Reporter:	Ilya V. Portnov <portnov>
Component:	General	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/krita/f1c69c15b2f59b4dc73860cb1cc83531f11b493e	Version Fixed/Implemented In:
Sentry Crash Report:

Description Ilya V. Portnov 2015-07-11 14:59:56 UTC

1. If you dig http://www.davidrevoy.com/data/documents/2015-04-17_deevadkrita_V6.bundle, you will see that manifest.xml refers to some resources that do not exist in this bundle. In this case they are rushes/bird.gih and patterns/4-paper-soft-grain_teststrong.pat. I bet this bundle was created by deevad using krita, but somehow manifest.xml is not consistent with actual content of bundle.

2. If you check out bundle file at http://galatejaa.deviantart.com/art/Pastel-530782158, you will see that it contains presets that refer to brushtip files that do not exist in the same bundle. So the bundle file is actually  unusable. I think Krita should at least warn user when trying to create such bundle.

Reproducible: Always

Comment 1 Halla Rempt 2016-03-25 13:43:39 UTC

Git commit f1c69c15b2f59b4dc73860cb1cc83531f11b493e by Boudewijn Rempt.
Committed on 25/03/2016 at 13:42.
Pushed by rempt into branch 'master'.

If a preset needs a brush tip file, this is now automatically added
on saving the bundle.

M  +8    -1    plugins/extensions/resourcemanager/resourcemanager.cpp

http://commits.kde.org/krita/f1c69c15b2f59b4dc73860cb1cc83531f11b493e