Bug 350075

Summary: Import of recipes takes too long
Product: [Unmaintained] krecipes Reporter: Vit Pelcak <vit>
Component: generalAssignee: Unassigned bugs <unassigned-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: 2.0-beta2   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: http://commits.kde.org/krecipes/aea810e290ce605c0255aea56c9652744a8244ae Version Fixed/Implemented In:
Sentry Crash Report:

Description Vit Pelcak 2015-07-10 06:03:28 UTC 
When I want to import mmf file of recipes, it takes very long. It is roughly one recipe per second. I had imported some 14k recipes and it took whole night.

Also deleting recipes takes ages. Deleting some 10 of them can take whole minute.

I use SQLite as database.

I spotted, that during import only one thread is used which in todays time of multicores and hyper threading is waste of time.

Could you please work on some improvements?

Reproducible: Always
Comment 1 Vit Pelcak 2015-07-10 09:15:00 UTC 
You can download databases for import for testing here: http://www.ffts.com/recipes.htm
Comment 2 José Manuel Santamaría Lema 2016-02-26 12:39:35 UTC 
Git commit aea810e290ce605c0255aea56c9652744a8244ae by José Manuel Santamaría Lema.
Committed on 26/02/2016 at 12:38.
Pushed by joselema into branch 'master'.

Use transactions when exporting recipes.

This reduces a lot the time to get a large number of recipes into the database.

M  +18   -3    src/backends/qsqlrecipedb.cpp
M  +4    -0    src/backends/qsqlrecipedb.h
M  +5    -0    src/backends/recipedb.h
M  +12   -0    src/importers/baseimporter.cpp

http://commits.kde.org/krecipes/aea810e290ce605c0255aea56c9652744a8244ae