| Summary: | KDevelop closes too much files after review is finished | ||
|---|---|---|---|
| Product: | [Developer tools] kdevplatform | Reporter: | Piotr Mierzwinski <piotr.mierzwinski> |
| Component: | patchreview | Assignee: | kdevelop-bugs-null |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | normal | CC: | david.nolden.kde, mail, piotr.mierzwinski |
| Priority: | NOR | Keywords: | usability |
| Version First Reported In: | git master | ||
| Target Milestone: | --- | ||
| Platform: | Mageia RPMs | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
This is related with issue: https://bugs.kde.org/show_bug.cgi?id=346893 Second scenario where the problem is reproduced: Steps to Reproduce: 1. run KDevelop with any project 2. open 4 file 3.. change one of them 4. invoke commit (I call context menu clicking in top item in Project view and selecting Git->Commit) I get Review perspective with two opened file: Overview and changed file. 5. Confirm commit in "Review" view Code perspective is restored, but without changed file Actual Results: Changed file is closed. I have only other files. Expected Results: As before. All opened file before commit should be restored after commit will be done. All tests I'm doing with following project: git://git.qtcmd.org/qtcmd2.git *** This bug has been marked as a duplicate of bug 351895 *** |
In KDevelop I have opened two files files (one is from outside of project) second changed previously, but saved currently. I want to see all changes in my project, so I click right mouse button in project name (top item) in Project View, go to Git -> Show differences. Now I can see all changed files (in my case 5 files). Now I close review clicking "Finish review" (in "Review" view). I get only one opened file (this one from outside of project). Previously (before checking changes) opened file has been also closed. Reproducible: Always Steps to Reproduce: There is git project where git status shows none changed files. 1. change couple of files (for example 5) in some editor (kate, vim, other) and save the changes 2. open KDevelop (tested on cloned from git master at 2015.07.06) 3. open one file outside of project (text file) and one changed previously I suppose that first file has not to be outside of project, and might be any not changed before. I tested only with file which came outside of project. 4. check the differences in project. I click right mouse button in project name (top item) in Project View, go to Git -> Show differences. All differences should be shown in "Review" perspective 5. close Review perspective. I close review clicking "Finish review" (in "Review" view) Actual Results: Almost all files (except file out side of project) have been closed. Expected Results: File which came from outside of project and file which has been changed before showing differences have been opened after back to Code perspective. In other words. I expect all opened files which were opened before "Show differences" was invoked - all files from before "Show differences" should be restored.