Bug 349554

Summary:	Deform brush does not take canvas rotation into consideration
Product:	[Applications] krita	Reporter:	Tyson Tan <tysontanx>
Component:	Brush engines	Assignee:	vanyossi <ghevan>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	halla, herrkjeldsen
Priority:	NOR
Version:	2.9.4
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/69e65a8d5a2394f2f4f4dedd5b29b46822a758c1	Version Fixed In:
Sentry Crash Report:

Description Tyson Tan 2015-06-24 02:21:02 UTC

Move_tool (brush preset) does not work properly when canvas is rotated using Shift+Middle stylus button drag. The direction of movement is always locked to 0 degree regardless of the rotation of the canvas.

Reproducible: Always

Steps to Reproduce:
1. Create a new document;
2. Draw a web with intersecting lines like a fish net;
3. Shift+Middle stylus button, rotate the canvas90 degrees clockwise;
4. Use brush tool, select Move_tool preset, draw a stroke from left to right;

Actual Results:  
Although the stroke was from left to right, resulted transformation was from bottom to up.

Expected Results:  
Move_tool moves the content to correct direction no matter what degree the canvas is rotated.

Comment 1 Halla Rempt 2015-08-18 09:23:41 UTC

Hi Tyson,

Thanks for your report. I can reproduce the issue. I have no idea yet about fixing it, though... Let's see!

Comment 2 Halla Rempt 2015-08-18 10:10:46 UTC

Git commit 69e65a8d5a2394f2f4f4dedd5b29b46822a758c1 by Boudewijn Rempt.
Committed on 18/08/2015 at 10:10.
Pushed by rempt into branch 'calligra/2.9'.

It causes rounding errors.

M  +0    -14   krita/plugins/paintops/hairy/kis_hairy_paintop_settings.cpp
M  +1    -1    krita/plugins/paintops/hairy/kis_hairy_paintop_settings.h

http://commits.kde.org/calligra/69e65a8d5a2394f2f4f4dedd5b29b46822a758c1

Comment 3 Halla Rempt 2015-08-18 10:11:42 UTC

Eek. wrong commit.

Comment 4 Marcus Kjeldsen 2016-04-10 09:43:35 UTC

I can confirm on 3.0 Alpha 1 on win 10 :)

Comment 5 vanyossi 2019-05-24 17:02:55 UTC

This bug is elusive. I was able to make it happen once in master 69a7444

Comment 6 vanyossi 2019-08-12 20:18:59 UTC

I can't reproduce the bug as described in the bugreport or anyother way I thinked about. Closing.

Please reopen if you still get this behaviour