| Summary: | Collection merging for large file catalogs seems inefficient | ||
|---|---|---|---|
| Product: | [Applications] tellico | Reporter: | Robby Stephenson <robby> |
| Component: | general | Assignee: | Robby Stephenson <robby> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 2.3.10 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/tellico/94fab242628ed4b1bf50685a06e829b8812fd6e8 | Version Fixed In: | 3.2 |
| Sentry Crash Report: | |||
|
Description
Robby Stephenson
2015-06-20 11:09:03 UTC
Git commit 94fab242628ed4b1bf50685a06e829b8812fd6e8 by Robby Stephenson. Committed on 11/02/2019 at 02:08. Pushed by rstephenson into branch 'master'. Check if entry match is good enough after every field comparison Avoid needless comparisons if the threshold for a perfect match is already met. FIXED-IN: 3.2 M +5 -1 ChangeLog M +5 -4 src/collection.cpp M +8 -0 src/collections/bookcollection.cpp M +23 -11 src/collections/comicbookcollection.cpp M +6 -5 src/collections/filecatalog.cpp M +12 -9 src/collections/musiccollection.cpp M +18 -11 src/collections/videocollection.cpp M +5 -3 src/entrycomparison.cpp M +4 -3 src/entrycomparison.h https://commits.kde.org/tellico/94fab242628ed4b1bf50685a06e829b8812fd6e8 Git commit 965a6040538b9b0a21c5267d2f3b0124182fe6ce by Robby Stephenson. Committed on 11/02/2019 at 01:52. Pushed by rstephenson into branch 'master'. Optimize Document::mergeCollection() a bit Remove comparison of title with articles removed. The time needed to strip articles is very onerous in a big collection comparison and other fields should allow the entry to match, even if one title has an article and the other doesn't. M +5 -6 src/document.cpp M +1 -1 src/entry.cpp M +32 -27 src/entrycomparison.cpp M +2 -2 src/entrycomparison.h M +3 -1 src/fieldformat.cpp M +18 -18 src/tests/collectiontest.cpp https://commits.kde.org/tellico/965a6040538b9b0a21c5267d2f3b0124182fe6ce |