| Summary: | Dolphin should consider sshfs-mounted directories to be network resources for the purpose of determining when to show thumbnails | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Albert Vaca Cintora <albertvaka> |
| Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | REOPENED --- | ||
| Severity: | normal | CC: | a.samirh78, bharadwaj.raju777, bugseforuns, elvis.angelaccio, frank78ac, justin.zobel, kdelibs-bugs-null, magunasu.b97, meven29, michael.gehringer, nate, postix, simonandric5 |
| Priority: | NOR | Keywords: | efficiency-and-performance |
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=465907 | ||
| Latest Commit: | https://invent.kde.org/frameworks/kio/commit/afb37351506046272adcfd05213a9c5fa697e9fc | Version Fixed In: | |
| Sentry Crash Report: | |||
| Bug Depends on: | |||
| Bug Blocks: | 504984 | ||
| Attachments: | Screenshot | ||
|
Description
Albert Vaca Cintora
2015-06-14 19:09:11 UTC
Created attachment 93173 [details]
Screenshot
First of all, thanks for the bug report. This is not really a Dolphin issue - you will most likely see the same problem in the file dialog and anywhere else in KDE software where you can view directories and enable thumbnails. Moreover, Dolphin does not know at all how directories that are accessed with "file:" URLs are mounted. If the behavior needs to be changed, then it must be done in KIO's PreviewJob. Currently, PreviewJob has special handling for non-"file:" URLs and creates thumbnails only for files up to a size which you can configure, e.g., in Dolphin's settings dialog. However, note that changing KIO's behavior with respect to file systems like sshfs has been proposed in the past (see, e.g, bug 348038), and the conclusion was that using sshfs is wrong, and you should use the fish kioslave instead. The configured size limit for remote files will then be respected by the preview generator. I'll reassign this report to KIO, but since KIO already has a very sophisticated system for dealing with this kind of issue that makes sshfs mounts unnecessary, you should probably consider accessing the device via "fish:" URLs. This will also prevent problems like bug 348038, which is much worse than the thumbnail issue. > "using sshfs is wrong, and you should use the fish kioslave instead"
> "makes sshfs mounts unnecessary"
Yeah, because Plasma is the one and only desktop environment in the universe, right? ;)
Thanks for reassigning to the right team, I hope this can be reconsidered because currently it's a blocker for KDE Connect on Plasma 5.
In any case, I think that we should not stop creating thumbnails for sshfs-mounted directories altogether. Files smaller than the user-configurable size limit for remote files should definitely get thumbnails. I don't think the same limit makes sense: it's not the same to read 200 2MB images from an SSD disk, which takes a few seconds, than over the network, which can take minutes (and likely freeze dolphin while it reads the files). (In reply to Albert Vaca from comment #5) > I don't think the same limit makes sense: it's not the same to read 200 2MB > images from an SSD disk, which takes a few seconds Maybe you misunderstood what I meant. There is no file size limit for the thumbnail generation for files on local devices. I meant that the size limit for remote files could be used also for sshfs mounts. This is definitely better than never generating thumbnails for sshfs folders. Oh, sorry. Yes, that would make a lot of sense! :D *** Bug 348038 has been marked as a duplicate of this bug. *** Can confirm it is still generating thumbnails for images, etc. Git commit afb37351506046272adcfd05213a9c5fa697e9fc by Ahmad Samir, on behalf of Bharadwaj Raju. Committed on 02/02/2022 at 09:54. Pushed by ahmadsamir into branch 'master'. Consider slow files as remote files in previewjob Consider files which are slow according to `KFileItem::isSlow()` as remote files. This makes browsing FUSE remote mounts (like with rclone) much smoother. Such mounts are still `isLocalFile()`, even though they represent a remote resource. Related: bug 372849 M +1 -1 src/widgets/previewjob.cpp https://invent.kde.org/frameworks/kio/commit/afb37351506046272adcfd05213a9c5fa697e9fc Is there an option to force thumbnails to be shown anyway? This completely wrecks my workflow with my NFS storage and I've reverted the commit to regain sanity for now. The commit from comment#11 was reverted https://invent.kde.org/frameworks/kio/-/commit/be7d351a8ac4cccc5e66b1d278326e6f26ead1c0 Had to be reverted unfortunately as it caused regression https://invent.kde.org/frameworks/kio/-/commit/be7d351a8ac4cccc5e66b1d278326e6f26ead1c0 We will revisit this, once we have improved our ntfs/fuse detection. |