Summary: | Spell-Check No longer working | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-sonnet | Reporter: | Marco Parillo <marco_parillo> |
Component: | general | Assignee: | Martin Sandsmark <martin.sandsmark> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | contact, hein, jesse.jaara, kdelibs-bugs, rdieter, shafff |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Kubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: |
Output from CMake
CMake Error Log |
Description
Marco Parillo
2015-06-14 14:37:07 UTC
No changes on the Konversation side, reassigning to Sonnet. Other Information: I can get UK English Spelling Checking from System Settings > Regional Settings > Spell Check and changing from US English to American English (United States) [GB], applying and re-starting konversation. However, when I try to go back to System Settings > Regional Settings > Spell Check to re-set back to US English, that option is now missing entirely. I'd suggest installing aspell-en or so. (In reply to Eike Hein from comment #3) > I'd suggest installing aspell-en or so. I think I have it installed: apt-cache policy aspell-en aspell-en: Installed: 7.1-0-1.1 Candidate: 7.1-0-1.1 Version table: *** 7.1-0-1.1 0 500 http://us.archive.ubuntu.com/ubuntu/ wily/main i386 Packages 100 /var/lib/dpkg/status I can confirm this bug. Reproducing steps: 1. Open ~/.config/KDE/Sonnet.conf 2. Set defaultLangauge to an invalid value Setting 'defaultLangauge' in "~/.config/KDE/Sonnet.conf" to an invalid value (language with no dictionarys available) breaks the red line. Changing the language on runtime does not help, if a valid dictionary is selected at runtime suggestions come in as expected, but red line does not appear. Problem is present at git-HEAD. can you retry after installing hunspell-en-us ? (In reply to Nick Shaforostoff from comment #7) > can you retry after installing hunspell-en-us ? It is already installed: apt-cache policy hunspell-en-us hunspell-en-us: Installed: 20070829-6ubuntu2 Candidate: 20070829-6ubuntu2 Version table: *** 20070829-6ubuntu2 0 500 http://us.archive.ubuntu.com/ubuntu/ wily/main i386 Packages 100 /var/lib/dpkg/status in vanilla ode the hunspell plugin was looking in /usr/share/myspell/dicts for dictionaries, but at least in debian and ubuntu they are installed into /usr/share/hunspell. so i have added this path alternative to git HEAD: https://projects.kde.org/projects/frameworks/sonnet/repository/revisions/master/entry/src/plugins/hunspell/hunspellclient.cpp (see in the bottom) maybe with that it will start working? also, can you specify the last version of konversation + KF/kdelibs where spellcheck was working for you? For what it's worth, fedora/redhat uses (just) /usr/share/myspell , so I ended up using: http://pkgs.fedoraproject.org/cgit/kf5-sonnet.git/tree/sonnet-5.10.0-myspell_path.patch Does *anyone* still use /usr/share/myspell/dicts ? (if not, maybe that one can be dropped and replaced with /usr/share/myspell) Too bad hunspell seems to have no api to query for dictionary paths :( ok, I will adapt sonnet code to /usr/share/myspell as well later this evening. also i'm thinking about a CMake test to set up the directory which sonnet should check first in order to minimize disk queries on application startup... Git commit 0e6edac621fbd366b126ebd851fbea21355e02d0 by Nick Shaforostoff. Committed on 15/09/2015 at 22:25. Pushed by shaforo into branch 'master'. CHANGELOG: look for dicts in /usr/share/hunspell by default, this is a hunspell plugin, right? CHANGELOG: add compile-time check to use /usr/share/myspell if /usr/share/hunspell doesn't exist CHANGELOG: fix Highlighter::setCurrentLanguage() for the case when previous language was invalid note: i had spellcheck broken on my machine because i had installed myspell-ru which uses KOI8-R encoding, while hunspell-ru uses UTF-8 as expected M +7 -12 src/core/loader.cpp M +6 -0 src/plugins/hunspell/CMakeLists.txt M +7 -11 src/plugins/hunspell/hunspellclient.cpp M +4 -9 src/plugins/hunspell/hunspelldict.cpp M +13 -5 src/plugins/hunspell/hunspelldict.h M +4 -3 src/ui/highlighter.cpp http://commits.kde.org/sonnet/0e6edac621fbd366b126ebd851fbea21355e02d0 Marco, can you test the change? if you need assistance with building and installing sonnet i'm ready to help you (In reply to Nick Shaforostoff from comment #13) > Marco, can you test the change? if you need assistance with building and > installing sonnet i'm ready to help you I know I can install a .deb, but I do not know how to create one. Do I need to: 1: Extract the source, and I assume place it in a temporary directory (Is there some kind of git command)? 2: Compile the source (Is there a make, and how do I invoke it)? 3: Create the package (Is that a debbuild, or something like that?) 4: Install the package (I can do that, assuming the .deb resolves any dependencies) sudo apt-get install cmake libkf5sonnet-dev git git clone git://anongit.kde.org/sonnet mkdir sonnet/build cd sonnet/build cmake .. #here check for errors and install missing -dev packages if needed make sudo cp ./src/plugins/hunspell/hunspell.so /usr/lib/x86_64-linux-gnu/qt5/plugins/kf5/sonnet/hunspell.so after that you can return to original state by issuing apt-get install --reinstall sonnet-plugins Created attachment 94612 [details]
Output from CMake
Created attachment 94613 [details]
CMake Error Log
This appears to be resolved with the daily builds of Kubuntu 16.04 after upgrading Plasma to 5.5.3 and Qt to 5.5.1. |