Bug 349111

Summary:	Email addresses of authors are not visible
Product:	[Applications] gcompris	Reporter:	Alexander Potashev <aspotashev>
Component:	general	Assignee:	Bruno Coudoin <bruno.coudoin>
Status:	CLOSED FIXED
Severity:	normal	CC:	jazeix
Priority:	NOR
Version:	git master
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed In:

Description Alexander Potashev 2015-06-13 17:39:36 UTC

For example, in src/activities/lightsoff/ActivityInfo.qml the author fields contains an email address in angle brackets. But this email address in not visible in the UI because it's not valid HTML code.

Please either always escape the author field in HTML or use HTML "mailto:" links.

Reproducible: Always

Comment 1 Jazeix Johnny 2015-06-13 20:28:58 UTC

Thanks for the report.

Should be fixed in http://quickgit.kde.org/?p=gcompris.git&a=commit&h=321c9d882bb67451dbdb5b2d063a48b3078a453c

Comment 2 Alexander Potashev 2015-06-13 20:58:05 UTC

wow
such fast
much love

Please use a "BUG: <bug-id>" line in the commit message next time you push a bug fix.
https://techbase.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages

There are still some unescaped email addresses, but I don't know if they are visible in the UI:
tools/menus/algebra_guesscount.qml
tools/menus/anim.qml
tools/menus/braille_lotto.qml
tools/menus/chat.qml
tools/menus/chess_computer.qml
tools/menus/chess_movelearn.qml
tools/menus/chess_partyend.qml
tools/menus/doubleentry.qml
tools/menus/draw.qml
tools/menus/electric.qml
tools/menus/explore_farm_animals.qml
tools/menus/explore_world_animals.qml
tools/menus/explore_world_music.qml
tools/menus/hydroelectric.qml
tools/menus/land_safe.qml
tools/menus/lang-nature.qml
tools/menus/lang-object.qml
tools/menus/lang-other.qml
tools/menus/lang-people.qml
tools/menus/maze3D.qml
tools/menus/melody.qml
tools/menus/note_names.qml
tools/menus/paintings.qml
tools/menus/paratrooper.qml
tools/menus/piano_composition.qml
tools/menus/place_your_satellite.qml
tools/menus/play_piano.qml
tools/menus/play_rhythm.qml
tools/menus/railroad.qml
tools/menus/readingh.qml
tools/menus/readingv.qml
tools/menus/searace.qml
tools/menus/searace1player.qml
tools/menus/submarine.qml
tools/menus/watercycle.qml

Comment 3 Jazeix Johnny 2015-06-13 21:36:53 UTC

They are not visible in the UI but I still fixed them (except for reading{h,v}.qml as I'm working on them and I'll commit them fixed later).
I used the good syntax but I don't have access yet (You are not allowed to change the bug status from UNCONFIRMED to RESOLVED.), I'll check this issue later :)