Bug 349002

Summary:	ConnectionDetailEditor UI is broken while waiting for secrets
Product:	[Applications] systemsettings	Reporter:	Alexander Potashev <aspotashev>
Component:	kcm_networkmanagement	Assignee:	Lukáš Tinkl <lukas>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugs.kde.org.trustful938, jgrulich
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:	http://commits.kde.org/plasma-nm/2d7a689b79d6ca9752ada7ccdc1e635149d2ba36	Version Fixed In:
Sentry Crash Report:
Attachments:	screenshot of D-Bus error message

Description Alexander Potashev 2015-06-10 20:54:54 UTC

I connected to a WiFi network and chose to save the password. After that when I click "Edit..." to edit this connection in the plasma-nm connection editor, the dialog opens immediately but it contains only a lineedit with the name of the connection, no other widgets below. In a few seconds I get a "Failed to get secrets for %1" notification and the dialog is fully initialized (except for the password field which is empty.)

What happens under the hood: ConnectionDetailEditor::initEditor() makes an async D-Bus request to retrieve the password, but the request times out somehow on my installation (I don't know why) and so the dialog is not initialized until the request finishes with an error.

While it's waiting for the D-Bus request to finish, the user is not informed of what is happening and why the dialog is half baked. I think the dialog should be initialized at most without waiting for reply from D-Bus, and probably add some warning/progress label next to the password field to let the user know that the password is still being loaded.

Reproducible: Always

Comment 1 Alexander Potashev 2015-06-10 21:09:35 UTC

Created attachment 93113 [details]
screenshot of D-Bus error message

Comment 2 Lamarque V. Souza 2015-07-06 16:40:52 UTC

*** Bug 349796 has been marked as a duplicate of this bug. ***

Comment 3 Jan Grulich 2015-07-09 18:52:48 UTC

Git commit 2d7a689b79d6ca9752ada7ccdc1e635149d2ba36 by Jan Grulich.
Committed on 09/07/2015 at 18:52.
Pushed by grulich into branch 'master'.

Make loading of secrets in the editor asynchronous

This make the UI of the configuration load immediately, instead of
waiting for NM response.

REVIEW:124279

M  +1    -1    editor/connectioneditor.h
M  +20   -10   libs/editor/connectiondetaileditor.cpp
M  +15   -2    libs/editor/settings/cdmawidget.cpp
M  +1    -0    libs/editor/settings/cdmawidget.h
M  +21   -4    libs/editor/settings/gsmwidget.cpp
M  +1    -0    libs/editor/settings/gsmwidget.h
M  +14   -1    libs/editor/settings/pppoewidget.cpp
M  +1    -0    libs/editor/settings/pppoewidget.h
M  +29   -6    libs/editor/settings/security802-1x.cpp
M  +2    -0    libs/editor/settings/security802-1x.h
M  +43   -2    libs/editor/settings/wifisecurity.cpp
M  +2    -0    libs/editor/settings/wifisecurity.h
M  +9    -0    libs/editor/settings/wiredsecurity.cpp
M  +1    -0    libs/editor/settings/wiredsecurity.h
M  +2    -1    libs/editor/widgets/settingwidget.cpp
M  +1    -1    libs/editor/widgets/settingwidget.h
M  +15   -6    vpn/l2tp/l2tpwidget.cpp
M  +2    -1    vpn/l2tp/l2tpwidget.h
M  +21   -11   vpn/openswan/openswanwidget.cpp
M  +2    -1    vpn/openswan/openswanwidget.h
M  +20   -13   vpn/openvpn/openvpnwidget.cpp
M  +3    -1    vpn/openvpn/openvpnwidget.h
M  +17   -9    vpn/pptp/pptpwidget.cpp
M  +4    -1    vpn/pptp/pptpwidget.h
M  +17   -4    vpn/ssh/sshwidget.cpp
M  +4    -1    vpn/ssh/sshwidget.h
M  +18   -4    vpn/sstp/sstpwidget.cpp
M  +4    -1    vpn/sstp/sstpwidget.h
M  +29   -4    vpn/strongswan/strongswanwidget.cpp
M  +3    -1    vpn/strongswan/strongswanwidget.h
M  +21   -11   vpn/vpnc/vpncwidget.cpp
M  +2    -1    vpn/vpnc/vpncwidget.h

http://commits.kde.org/plasma-nm/2d7a689b79d6ca9752ada7ccdc1e635149d2ba36