| Summary: | dialog.cpp:414: bad if statement ? | ||
|---|---|---|---|
| Product: | [Unmaintained] wacomtablet | Reporter: | dcb314 |
| Component: | general | Assignee: | Jörg Ehrichs <Joerg.Ehrichs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/wacomtablet/067c94da50bf495af44f8c8a8c0d1dfec392d5ee | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
Git commit 067c94da50bf495af44f8c8a8c0d1dfec392d5ee by Valeriy Malov. Committed on 01/04/2018 at 18:05. Pushed by valeriymalov into branch 'master'. Fix status led values in tablet finder This seems like a couple of typos. Overall whole StatusLED property seems to be very odd since it's actually never ever used outside a check in TabletBackend::setStatusLED, so hopefully I'm not breaking anything. M +3 -3 src/tabletfinder/dialog.cpp https://commits.kde.org/wacomtablet/067c94da50bf495af44f8c8a8c0d1dfec392d5ee |
[../../../src/tabletfinder/dialog.cpp:414] -> [../../../src/tabletfinder/dialog.cpp:414]: (style) Same expression on both sides of '&&'. if(t.hasStatusLEDsLeft && t.hasStatusLEDsLeft) { leds = 8; } else if(t.hasStatusLEDsLeft || t.hasStatusLEDsLeft) { leds = 4; } Reproducible: Always