| Summary: | Quick launch icons are really tiny when compositing is disabled. | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Mark <markg85> |
| Component: | Task Manager and Icons-Only Task Manager widgets | Assignee: | Eike Hein <hein> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | plasma-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Without compositing
With compositing |
||
|
Description
Mark
2015-06-07 13:03:46 UTC
Created attachment 93051 [details]
Without compositing
Created attachment 93052 [details]
With compositing
It looks like all other icons are slightly smaller without compositing as well. Just not as tiny as the quick launch icons. This is on a regular sized monitor (24" 1920x1200) no HiDPI/QHD stuff. It's because of different margin sizes in the theme elements. (In reply to Eike Hein from comment #4) > It's because of different margin sizes in the theme elements. What do you mean? Is the task manager using different margins when compositing is not used which in turn causes smaller icons for the task manager? Yes, but it's probably the panel, not the Task Manager. Plasma themes can provide different SVGs for compositing on/off. The icon sizes are affected by two elements, the panel 9-patch (since its border sub-elements affect the Task Manager size) and the Task button 9-patch (since its border sub-elements affect the icon size). (In reply to Eike Hein from comment #6) > Yes, but it's probably the panel, not the Task Manager. Plasma themes can > provide different SVGs for compositing on/off. The icon sizes are affected > by two elements, the panel 9-patch (since its border sub-elements affect the > Task Manager size) and the Task button 9-patch (since its border > sub-elements affect the icon size). Why? WHY? Really, why? "I" don't think compositing should alter the layout of items. Just the visual effects. Sure, you might want to provide a different panel background when compositing is disabled/enabled because compositing does some effects there. But that's - in my opinion - as far as one should go with differences between enabled and disabled compositing. Icons - definitely icons! - should be unaffected. Anything size related should not change. I'm just explaining what I think is going on, not postulating an opinion for you to disagree with. Please try to keep your ego in check, it's very annoying and off-putting. Without having looked at the SVGs in question (I'm not at the desk right now), the answer to 'Why?' is probably that the panel border styling is different to account for the lack of a panel shadow in a non-compositing case, along with the different background, and at some point one version got edited without making sure the other is in sync in terms of producing identical visual results. Ok, keeping ego in check. The way you describe it in #8 sounds like a bug (which is what i initially thought and why i posted this bug report in the first place). The way you described it a few posts ago it sounded like a "feature". So now i'm a bit puzzled. Is this a bug or a feature? That the SVG elements can be tuned for each case is a feature, that the icon size changes is a bug, otherwise I'd have closed the ticket after all ... (In reply to Eike Hein from comment #10) > That the SVG elements can be tuned for each case is a feature, that the icon > size changes is a bug, otherwise I'd have closed the ticket after all ... Ok, got it. But does that also explain why for instance the kickoff icon is slightly smaller when compositing is disabled? If it does then this bug isn't in the task manager, but in the breeze theme i guess. And not only for the SVG's that affect the tasks, but in more places. ^ It can't be in the Task Manager, there's no code fork depending on compositing state. It's in the theme, yes. I fixed the Breeze theme at a later time. |