Bug 348826

Summary:	2.9.5 Selecting previous preset not working with brush docker
Product:	[Applications] krita	Reporter:	JA12 <jani.vartinen>
Component:	Dockers	Assignee:	Stefano Bonicatti <smjert>
Status:	RESOLVED FIXED
Severity:	normal	CC:	griffinvalley, info, smjert
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/603562c56d1ecc21853319457cc2100b4894d862	Version Fixed/Implemented In:
Sentry Crash Report:

Description JA12 2015-06-07 11:31:20 UTC

Selecting two brushes from the brush docker doesn't allow to use previous preset hotkey. It only works when selecting brushes from the popup palette.

Reproducible: Always

Steps to Reproduce:
1. Select two brushes from brushes docker
2. Numpad / to switch brushes

Actual Results:  
Brushes won't switch between the two. It might switch to the default basic brush.

Expected Results:  
Switching between selected brushes. Worked on 2.9.4

Comment 1 wolthera 2015-06-07 11:32:15 UTC

Can confirm this.

Comment 2 David REVOY 2015-06-12 03:38:47 UTC

Confirmed here too. 
Thanks for the workaround with 'pop-up palette'.

Comment 3 Stefano Bonicatti 2015-06-12 16:32:37 UTC

This will be a bit tougher than i thought, i've found the commit that introduced the bug (b2cc77e89e4c246734f910db171f62afd2ad1ada), but it's a fix to another bug (348120).
FIxing this without reinserting the old bug will be difficult, especially since there's an event hell in between (there are 5 calls to KoResourceItemChooser::activated with alternating resource pointer, the old resource and currently clicked, while there should be only 1)

Comment 4 David REVOY 2015-06-12 17:03:27 UTC

I can live easily with Bug 348120 so if it's the only short-term solution I would have no problem to see it reverted to make ' / ' work as it was before. 

This bug is my top annoying of the moment, I'm living with the 'right-click palette wheel work-around' but it takes more time ( my stylus don't have button, I need to switch to the mouse to feed 'preset history' )  , and it's drive my energy down while painting. 
I really hope it's not inside 2.9.5 release because I recommend this feature on all my tutorials as a basic and think it's a core usability feature.

Comment 5 Stefano Bonicatti 2015-06-12 17:12:22 UTC

(In reply to David REVOY from comment #4)
> I can live easily with Bug 348120 so if it's the only short-term solution I
> would have no problem to see it reverted to make ' / ' work as it was
> before. 
> 
> This bug is my top annoying of the moment, I'm living with the 'right-click
> palette wheel work-around' but it takes more time ( my stylus don't have
> button, I need to switch to the mouse to feed 'preset history' )  , and it's
> drive my energy down while painting. 
> I really hope it's not inside 2.9.5 release because I recommend this feature
> on all my tutorials as a basic and think it's a core usability feature.

Unfortunately it is because the change happened the 23th of May and the update to 2.9.5 is the 8th of June.
Though i already managed to reduce the amount of events (somewhere in the code an event was emitted even if the resource set was the same) and i have an idea how to fix the other bug without rewiring the clicked event.

Comment 6 Dmitry Kazakov 2015-06-17 13:18:50 UTC

Git commit 603562c56d1ecc21853319457cc2100b4894d862 by Dmitry Kazakov.
Committed on 17/06/2015 at 13:18.
Pushed by dkazakov into branch 'calligra/2.9'.

Revert b2cc77e89 "This makes it possible to select a resource even if there's only
one."

That commit broke '/' shortcut and introduces some other bugs
Related: bug 348120

M  +0    -1    libs/widgets/KoResourceItemChooser.cpp

http://commits.kde.org/calligra/603562c56d1ecc21853319457cc2100b4894d862