Bug 348768

Summary:	Changing through brushes from different engines and activating and deactivating erase mode causes the brushes to change blending modes
Product:	[Applications] krita	Reporter:	Raphael Barros <thebigheadone>
Component:	Usability	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	DarktaleHQ, halla, scottpetrovic, thebigheadone
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
URL:	http://youtu.be/8iMX27y9c_8
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Raphael Barros 2015-06-06 00:53:12 UTC

While drawing using mostly two brushes (a deforming one, with copy as blending mode, and a pixel one, with normal as blending mode), if I'm with the pixel one activated and activate the eraser (by pressing E), and than change to the deforming brush (which has copy as blending mode), if I go back to the pixel brush (still with the eraser activated) and deactivate the eraser, the blending mode changes to copy, instead of normal (it's default blending mode).

Reproducible: Always

Steps to Reproduce:
1.Get a pixel brush
2.Activate the eraser by pressing 'E'
3.Change your brush to another one with a different blending mode (I tested with other brushes and the results is the same, they just have to have different blending modes)
4.Go back to the original brush
5. Press 'E' to deactivate the eraser mode again

Actual Results:  
The brush "inherits" the blending mode from the previous brush.

Expected Results:  
It should instead go back to its original blending mode (which, in my case, was the normal mode).

Comment 1 Halla Rempt 2015-06-20 18:51:09 UTC

Hi Raphael,

Thanks for your report. I'm not sure what's going on, but I can confirm the issue.

Comment 2 Halla Rempt 2018-01-24 11:38:44 UTC

I think I fixed this in


commit 01294ad178d6e7fac321579f182880f58c5a5d0b
Author: Boudewijn Rempt <boud@valdyas.org>
Date:   Wed Jan 3 15:50:11 2018 +0100

    Do not share composite op models among composite op comboboxes
    
    It is perfectly valid for one composte op combobox to show
    a different set of valid composite ops than another, for instance
    if the image is rgb but the layer grayscale; a grayscale layer can
    be composited with rgb composite ops because it's converted to rgb
    beforehand.
    
    BUG:388464

Comment 3 Scott Petrovic 2018-05-22 19:38:08 UTC

I am marking this as resolved. Changing brush presets now resets the Eraser mode status and changes the brush composite op ok with my testing. If this is still an issue it can be re-opened